Updated the API get_platform_info() to return running/detected ASIC's count #16539

abdosi · 2023-09-13T16:18:21Z

What I did:

Updated the API get_platform_info() to return running/detected ASIC's count for given system

ADO: 25158825

Why I did:

In Chassis for supervisor running asic count can be <= max asic possible.
get_num_asics() return max asic count that can be present based on static asic.conf file eg:

sonic-buildimage/device/nokia/x86_64-nokia_ixr7250e_sup-r0/asic.conf

Line 1 in fe24c26

NUM_ASIC=16

. However in supervisor max_asic represnt number of asic where all Fabric cards are populated. However most of the time we have less than that inserted. get_asic_presence_list() returns how many Fabric asics are detected on Supervisor and for LC/Multi-asic system it still return max asic count as per asic.conf file

How I Verify:
Verified below commands on Chassis setup (multi-asic) and Pizza box with Single Asic

show version
show platform summary

peer device's Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

higher value so that BGP learnt default route is higher priority. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

…sis systrem" This reverts commit fcbd38d.

possible Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

gechiang · 2023-09-13T23:31:29Z

What kind of issue does this fix? Is this in particular to address issues such as some fabric card may not be present, so we need the running count instead of the max possible count?

abdosi · 2023-09-14T16:27:22Z

What kind of issue does this fix? Is this in particular to address issues such as some fabric card may not be present, so we need the running count instead of the max possible count?

yes that is the case. Also it's posssible some outside service can use the o/p from above commands to detect number of asic's on the system

arlakshm · 2023-09-14T16:36:11Z

src/sonic-py-common/sonic_py_common/device_info.py


    version_info = get_sonic_version_info()

    hw_info_dict['platform'] = get_platform()
    hw_info_dict['hwsku'] = get_hwsku()
    if version_info:
        hw_info_dict['asic_type'] = version_info.get('asic_type')
-    hw_info_dict['asic_count'] = get_num_asics()
+    hw_info_dict['asic_count'] = len(get_asic_presence_list())


can we put this change in try/catch to ensure show version when chassis_db is not up?

@arlakshm thanks. have updated accordingly.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

… Session" This reverts commit 3cf4697.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

gechiang · 2023-09-27T00:47:00Z

@arlakshm , can you re-review with the latest change that Abhishek committed?
Thanks!

mssonicbld · 2023-10-10T17:54:39Z

Cherry-pick PR to 202205: #16828

…ected ASIC's count (sonic-net#16539) previously, get_num_asics() returns the maximum number of asics. however, the asic_count should be actual number of asics populated which can be get from get_asic_presence_list(). ADO: 25158825 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

mssonicbld · 2023-10-10T17:54:44Z

Cherry-pick PR to 202211: #16829

…ected ASIC's count (#16539) previously, get_num_asics() returns the maximum number of asics. however, the asic_count should be actual number of asics populated which can be get from get_asic_presence_list(). ADO: 25158825 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

mssonicbld · 2023-10-13T22:33:22Z