202205 #16575
Closed
202205 #16575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Why I did it BIOS on new generation switch can come with a file type of cap or cab. Needs to add support to these file type. Also ONIE version on new devices can have a suffix of 'dev'. - How I did it Added cap & cab as possible component extensions for ComponentBIOS. Update the ONIE version regex to include dev signed versions. - How to verify it Update BIOS.
…et#15793) - Why I did it The reset cause "reset_from_comex" has been removed by hw-management, hence removing it from platform API code - How I did it Remove reset_from_comex from reboot cause mapping - How to verify it Manual test
= Why I did it To optimize Mellanox platform SAI build - How I did it SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release. - How to verify it Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
…tem health (sonic-net#15289) - Why I did it Adjust PSU power threshold logic in system health. - How I did it Update the description message in PSU power threshold checking power of PSU x (xx w) exceeds threshold (xx w) => System power exceeds xx threshold (xx w) - How to verify it Manual test and unit test
…D automatically (sonic-net#15852) #### Why I did it src/sonic-platform-daemons ``` * 94242c2 - (HEAD -> master, origin/master, origin/HEAD) Use vendor customizable fan speed threshold checks (sonic-net#378) (3 hours ago) [spilkey-cisco] * db6e340 - Fix index out of range in the error log of invalid media lane mask received (sonic-net#386) (8 hours ago) [MichaelWangSmci] ``` #### How I did it #### How to verify it #### Description for the changelog
#### Why I did it Reduced root directory privileges #### How I did it During build_debian - called chroot to reduce root directory and its subdirectories privileges to 744 #### How to verify it After image build and upgrade - check /root privileges by calling "ls -a /root" #### Description for the changelog reduced /root directory privileges
…lly (sonic-net#15860) #### Why I did it src/sonic-swss ``` * 5b27c209 - (HEAD -> master, origin/master, origin/HEAD) Refactor Orch class to separate recorder implementation (sonic-net#2837) (8 hours ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog
…face (sonic-net#15864) sonic-build image side change to fix source interface selection in dual tor scenario. dhcprelay related PR: [master]fix dhcpv6 relay dual tor source interface selection issue sonic-dhcp-relay#42 Announce dhcprelay submodule to 6a6ce24([to invoke sonic-net#40 PR]([master]fix dhcpv6 relay dual tor source interface selection issue sonic-dhcp-relay#42))
#### Why I did it event yang models for usage currently use int as type for usage leaf, needs to be of type decimal64 ##### Work item tracking - Microsoft ADO **(number only)**:17747466 #### How I did it Update yang models and UT #### How to verify it UT
…5890) Why I did it Fix the armhf build failure. How to reproduce the issue: docker run -it debain:bullseye bash apt-get update && apt-get install -y python3-pip pip3 install PyYAML==5.4.1 Error message: Collecting PyYAML==5.4.1 Installing build dependencies ... done Getting requirements to build wheel ... error ERROR: Command errored out with exit status 1: command: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl .... raise AttributeError(attr) AttributeError: cython_sources ---------------------------------------- WARNING: Discarding https://files.pythonhosted.org/packages/a0/a4/d63f2d7597e1a4b55aa3b4d6c5b029991d3b824b5bd331af8d4ab1ed687d/PyYAML-5.4.1.tar.gz#sha256=607774cbba28732bfa802b54baa7484215f530991055bb562efbed5b2f20a45e (from https://pypi.org/simple/pyyaml/) (requires-python:>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*). Command errored out with exit status 1: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl Check the logs for full command output. ERROR: Could not find a version that satisfies the requirement PyYAML==5.4.1 ERROR: No matching distribution found for PyYAML==5.4.1 root@fa2fa92edcfd:/# But if adding the option --no-build-isolation, then it is good, see fix. install "PyYAML==5.4.1" --no-build-isolation The same error can be found in the multiple builds. Work item tracking Microsoft ADO (number only): 24567457 How I did it Add a build option --no-build-isolation.
…lags in pcied (sonic-net#15896) Why I did it Certain all-numeric device IDs of PCI devices in the pcie.yaml file are left unquoted, leading to false mismatch flags in the pcie daemon and subsequently leads to log flooding. This PR fixes that issue. Work item tracking Microsoft ADO (number only): 24578930 How I did it Added quotes around numeric PCI devices in the pcie.yaml files of the following platforms: x86_64-mlnx_msn2700-r0 x86_64-mlnx_msn4600c-r0 How to verify it Install latest image after the merge and verify that syslogs are not flooded with PCI device mismatch errors
sonic-net#15885) #### Why I did it src/linkmgrd ``` * 6e5cfda - (HEAD -> master, origin/master, origin/HEAD) Change common_libs dependencies from buster to bullseye (sonic-net#212) (2 days ago) [Ze Gan] ``` #### How I did it #### How to verify it #### Description for the changelog
* Update WRED profile on system ports
#### Why I did it [Build] Fix the dash cache dependency issue ``` 12:47:34 [ finished ] [ target/files/bullseye/ctrmgrd.service ] 12:47:36 fatal: Unable to hash src/sonic-dash-api/sonic-dash-api 12:47:36 make: *** [Makefile.cache:528: target/debs/bullseye/libdashapi_1.0.0_amd64.deb.smdep] Error 123 12:47:36 make: *** Waiting for unfinished jobs.... ``` ##### Work item tracking - Microsoft ADO **(number only)**: 24547630
…lly (sonic-net#15908) #### Why I did it src/sonic-swss ``` * cb1b3f40 - (HEAD -> master, origin/master, origin/HEAD) Remove system neighbor DEL operation in m_toSync if SET operation for (sonic-net#2853) (7 hours ago) [Song Yuan] ``` #### How I did it #### How to verify it #### Description for the changelog
…rade ipython to 8.12.2 (sonic-net#15911) Upgrade celery in the python3 to 5.2.7, Upgrade ipython to 8.12.2 since 5.4.1 requires prompt-toolkit<2.0.0,>=1.0.4, But celery 5.2.7 relies click-repl>=0.2.0 , click-repl>=0.2.0 relies prompt-toolkit>=3.0.36. So upgrade ipython to resolve the prompt-toolkit version incompatible issue.
…lly (sonic-net#15921) #### Why I did it src/sonic-gnmi ``` * 610509b - (HEAD -> master, origin/master, origin/HEAD) Install necessary debs instead of entire artifact in azp (sonic-net#137) (2 hours ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Add support for a separate DEB_BUILD_PROFILES environment variable, to be able to set build profiles. This may be used to specify whether python 2 bindings/libraries should be built, or what configuration options should be specified for a package. This also makes it easier to append/remove build profiles from our rules files, which will be needed for the sairedis build. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
* DellEMC: S5248F update LED firmware
Why I did it To fix sonic-net/sonic-mgmt#8786 How I did it Modified Fan API to check whether the data retrieved is valid or not and return accordingly How to verify it Verify whether API 2.0 is loaded properly or not. Execute CLI's like "show version", "show interface status", "show platform psustatus" etc..
…onic-net#15368) * * platform/innoviunm: Add a new supported device and platform, SSE-T7132S * Switch Vendor: Supermicro * Switch SKU: Supermicro_sse_t7132s * ASIC Vendor: innovium * Swich ASIC: TL7 * Port Configuration: 32x400G * SONiC Image: SONiC-ONIE-Innoviunm Signed-off-by: wilsonw <wilsonw@supermicro.com.tw>
Add yang model for MUX_LINKMGR|MUXLOGGER.
Why I did it For route registry service, in order to block hijacked routes, IBGP session needs to be set up from BGP sentinel service to SONiC, and BGP sentinel service advertise the same route with higher local-preference and no export community. So that SONiC takes the route from BGP sentinel as the best path and does not advertise the route to EBGP peers. In order to do that, new route-maps are needed. So this change adds a new set of templates, keeping BGPSentinel peers out of the other templates. Work item tracking Microsoft ADO (number only): 24451346 How I did it Add sentinel_community in constants.yml, route from BGPSentinel do not match this community will be denied. Add support to convert BGPSentinel related configuration in the BGPPeerPassive element of the minigraph to a new BGP_SENTINELS table in CONFIG_DB Add a new set of "sentinels" templates to docker-fpm-frr Add a new BGP peer manager to bgpcfgd, to add neighbors from the BGP_SENTINELS table using the "sentinels" templates Add a test case for minigraph.py, making sure the BGPSentinel and BGPSentinelV6 elements create BGP_SENTINELS DB entry. Add a set of test cases for the new sentinels templates in sonic-bgpcfgd tests. Add sonic-bgp-sentinel.yang and a set of testcases for the yang file. How to verify it Testcases and UT newly added would pass. Setup IPv4 and IPv6 BGPSentinel services in minigraph, and load minigraph, show CONFIG_DB and "show runningconfig bgp", configuration would be loaded successfully. Using t1-lag topo and setup IBGP session from BGPSentinel to SONiC loopback address, IBGP session would up. Advertise route from BGPSentinel to T1 with sentinel_community, higher local-preference and no-export communiyt. In T1, show bgp route, the result is "Not advertise to any EBGP peer". Withdraw the route in BGPSentinel, in T1, route would advertise to EBGP peers. Advertise route from T1 that does not match sentinel_community, in T1, would not see the route in show bgp route.
- Why I did it To support the building of ARM-based docker-sonic-vs.gz - How I did it Fixed SYNCD_VS build rule to be architecture-specific. - How to verify it make configure PLATFORM=vs PLATFORM_ARCH=arm64 make target/docker-sonic-vs.gz Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
…ue (sonic-net#16507) Why I did it Add another cli entry: show dhcp_relay ipv4 counter Fix get all interface offset issue Work item tracking Microsoft ADO (17271822): How I did it show dhcp_relay ipv4 counter -i [ifname] show dhcp4relay_counters counts -i [ifname] How to verify it show dhcp4relay_counters counts | more 10 Message Type Ethernet144(RX)
* [swss] Chassis db clean up optimization and bug fixes
This commit includes the following changes:
- Fix for regression failure due to error in finding CHASSIS_APP_DB in
pizzabox (#PR 16451)
- After attempting to delete the system neighbor entries from
chassis db, before starting clearing the system interface entries,
wait for sometime only if some system neighbors were deleted.
If there are no system neighbors entries deleted for the asic coming up,
no need to wait.
- Similar changes for system lag delete. Before deleting the
system lag, wait for some time only if some system lag memebers were
deleted. If there are no system lag members deleted no need to wait.
- Flush the SYSTEM_NEIGH_TABLE from the local STATE_DB. While asic
is coming up, when system neigh entries are deleted from chassis ap
db (as part of chassis db clean up), there is no orchs/process running to
process the delete messages from chassis redis. Because of this, stale system
neigh are entries present in the local STATE_DB. The stale entries result in
creation of orphan (no corresponding data path/asic db entry) kernel neigh
entries during STATE_DB:SYSTEM_NEIGH_TABLE entries processing by nbrmgr (after
the swss serive came up). This is avoided by flushing the SYSTEM_NEIGH_TABLE from
the local STATE_DB when sevice comes up.
Signed-off-by: vedganes <veda.ganesan@nokia.com>
* [swss] Chassis db clean up bug fixes review comment fix - 1
Debug logs added for deletion of other tables (SYSTEM_INTERFACE and SYSTEM_LAG_TABLE)
Signed-off-by: vedganes <veda.ganesan@nokia.com>
---------
Signed-off-by: vedganes <veda.ganesan@nokia.com>
Why I did it Add dhcp_server ipv4 feature to SONiC. HLD: sonic-net/SONiC#1282 How I did it To be clarify: This container is disabled by INCLUDE_DHCP_SERVER = n for now, which would cause container not build. Add INCLUDE_DHCP_SERVER to indicate whether to build dhcp_server container Add docker file for dhcp_server, build and install kea-dhcp4 inside container Add template file for dhcp_server container services. Add entry for dhcp_server to FEATURE table in config_db. How to verify it Build image with INCLUDE_DHCP_SERVER = y to verify: Image can be install successfully without crush. By config feature state dhcp_server enabled to enable dhcp_server.
This feature was meant to be enabled but was accidentally left disabled. Also downgrades the select/deselect messages to KERN_INFO to reduce log spam. Fixes sonic-net#14546. Signed-off-by: Christian Svensson <blue@cmd.nu>
… space limit. (sonic-net#16516) * [ci] Disable building broadcom raw image because of S6100 device disk space limit.
…CS server failed. (sonic-net#16240) Write error message to syslog when add user failed or connect to TACACS server failed. #### Why I did it With these messages, we can downgrade TACACS server with issue to lower priority. ##### Work item tracking - Microsoft ADO: 24667696 #### How I did it Write error message to syslog when add user failed or connect to TACACS server failed. #### How to verify it Pass all UT. Manually verify error message generated. ### Description for the changelog Write error message to syslog when add user failed or connect to TACACS server failed.
…nic-net#16479) * [ci] For vstest, make sure kernel modules are built and installed Make sure that the agent that vstest runs on has the team module available. If it is not available, then build and install it. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Use version of script that's checked into sonic-swss-common Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
…in sonic-mgmt-docker (sonic-net#15836) Why I did it This PR is part of sonic-mgmt-docker Python3 migration project. Work item tracking Microsoft ADO (number only): 24397943 How I did it Upgrade Ansible to 6.7.0 Make Python3 as the default interpreter. python is a soft link to python3. If you want to use python2, use the command python2 explicitly. Upgrade some pip packages to higher version in order to meet security requirement. How to verify it Build a private sonic-mgmt-docker successfully. Verify python is python3. Verify python2 is working with 202012 and 202205 branch. Verify python3 is working with master branch.
### Why I did it Currently there is only rsyslog plugin support for /var/log/syslog, meaning we do not detect events that occur in frr logs such as BGP Hold Timer Expiry that appears in frr/bgpd.log. ##### Work item tracking - Microsoft ADO **(number only)**: 13366345 #### How I did it Add omprog action to frr/bgpd.log and frr/zebra.log. Add appropriate regex for both events. #### How to verify it sonic-mgmt test case
…rpreter in sonic-mgmt-docker (sonic-net#15836)" (sonic-net#16537) This reverts commit 51fb6d7. The new sonic-mgmt docker image has ansible upgraded. Encountered some issues that are hard to debug to have a quick fix. Let's revert the change for now. The new sonic-mgmt docker image was kept for further debugging and fixing. After all the issues are fixed, we'll need to apply this change again.
sonic-net#16527) Signed-off-by: anamehra anamehra@cisco.com Added a check for DEVICE_METADATA before accessing the data. This prevents the j2 failure when var is not available.
…low]ERR sflow#hsflowd: device Loopback0 Get SIOCGIFFLAGS failed : No such device sonic-net#13407 (sonic-net#15362) Signed-off-by: Gokulnath-Raja <Gokulnath_R@dell.com> Co-authored-by: mohanapriya-meganathan <mohanapriya.m1@dell.com>
Why I did it PTF container needs to use new grpcio package. Work item tracking Microsoft ADO (number only): How I did it Update versions-py2 How to verify it Check pipeline artifact
… automatically (sonic-net#16553) #### Why I did it src/sonic-platform-common ``` * 0dafb55 - (HEAD -> master, origin/master, origin/HEAD) Remove command to install libhiredis deb file (sonic-net#398) (9 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
…utomatically (sonic-net#16551) #### Why I did it src/sonic-host-services ``` * 1a5a0bf - (HEAD -> master, origin/master, origin/HEAD) Remove command to install libhiredis deb file (sonic-net#74) (8 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
…omatically (sonic-net#16531) #### Why I did it src/sonic-mgmt-common ``` * 14962fe - (HEAD -> master, origin/master, origin/HEAD) CVL database access layer changes (sonic-net#100) (30 hours ago) [Balachandar Mani] ``` #### How I did it #### How to verify it #### Description for the changelog
…c-net#16490) In sonic-net#15080, there was a command added to re-add 127.0.0.1/8 to the lo interface when the networking configuration is being brought down. However, the trigger for that command is `down`, which, looking at ifupdown2 configuration files, runs immediately after 127.0.0.1/16 is removed. This means there may be a period of time where there are no loopback addresses assigned to the lo interface, and redis commands will fail. Fix this by changing this to pre-down, which should run well before 127.0.0.1/16 is removed, and should always leave lo with a loopback address. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
…onic-net#15912) #### Why I did it The sflow debug container does not include the debug symbols of hsflowd. #### How I did it Add the hsflowd debug dependency. #### How to verify it Build the sflow debug container, get into the container, open gdb to load the hsflowd program. Verified debug symbol is available.
…16548) Why I did it ConfigDBConnector in supervisor-proc-exit-listener uses default parameter to connect CONFIG_DB (connect by 127.0.0.1:6379) which would fail at non-host network mode container, because they are not sharing the same network and socket. How I did it Add a new parameter use_unix_socket_path to this script to indicate whether to use socket to connect CONFIG_DB. How to verify it Build image and install it, kill critical processes in container and container crushed.
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
#### Why I did it Including below commits: ``` 2c6ed2e 2023-09-14 | Support interface speed for PortChannels (sonic-net#262) [Lukas Stockner] ``` ##### Work item tracking - Microsoft ADO **(number only)**: 25085425
smallqiang6
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)