[snmp] Sleep for 20 seconds before service starts #16588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
previously approved these changes
Sep 26, 2023
saiarcot895
reviewed
Sep 26, 2023
| @@ -10,6 +10,7 @@ StartLimitIntervalSec=1200 | |||
| StartLimitBurst=3 | |||
|
|
|||
| [Service] | |||
| ExecStartPre=-/usr/bin/sleep 20 | |||
There was a problem hiding this comment.
Can you test with ExecStartPre=/bin/bash -c "while pgrep intfmgrd > /dev/null; do sleep 1; done"? This has the advantage of documenting here that this needs the intfmgrd process to be running before this can be started (which in itself is a messy dependency) along with waiting only as much time as necessary before the snmp container is started.
There was a problem hiding this comment.
@saiarcot895, updated, now the start pre action will check for intfmgrd running for at most 20 seconds.
Add pre start check to ensure intfmgrd is running. The check will run for 20 seconds at most. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Oct 13, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 13, 2023
Add pre start check to ensure intfmgrd is running. The check will run for 20 seconds at most. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 13, 2023
Add pre start check to ensure intfmgrd is running. The check will run for 20 seconds at most. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
Cherry-pick PR to 202211: #16880 |
|
Cherry-pick PR to 202205: #16881 |
This was referenced Oct 13, 2023
yxieca
pushed a commit
that referenced
this pull request
Oct 14, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 17, 2023
Add pre start check to ensure intfmgrd is running. The check will run for 20 seconds at most. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
Cherry-pick PR to 202305: #16911 |
11 tasks
2 similar comments
mssonicbld
pushed a commit
that referenced
this pull request
Oct 20, 2023
Add pre start check to ensure intfmgrd is running. The check will run for 20 seconds at most. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Oct 21, 2023
Add pre start check to ensure intfmgrd is running. The check will run for 20 seconds at most. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixes #16486
Work item tracking
How I did it
As
snmpdepends onintfmgrdto work, let's add a check to ensureintfmgrdis running.The check will run for 20 seconds at most.
How to verify it
Do
config reloadand confirmssnmpdis started afterintfmgrdsetups all the loopback interfaces.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)