Enable ZMQ between GNMI and Orchanget #16661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends PR merged, close and re-open to trigger rebuild. |
ganglyu
approved these changes
Sep 26, 2023
qiluo-msft
reviewed
Sep 28, 2023
| @@ -69,4 +69,6 @@ else | |||
| ORCHAGENT_ARGS+="-m $MAC_ADDRESS" | |||
| fi | |||
|
|
|||
| ORCHAGENT_ARGS+=" -q tcp://127.0.0.1:8100" | |||
There was a problem hiding this comment.
As I know there is no flag for Dash, I will check and update this PR.
qiluo-msft
reviewed
Sep 28, 2023
| @@ -70,6 +70,8 @@ else | |||
| TELEMETRY_ARGS+=" -v=2" | |||
| fi | |||
|
|
|||
| TELEMETRY_ARGS+=" -zmq_address=tcp://127.0.0.1:8100" | |||
qiluo-msft
approved these changes
Oct 9, 2023
Pterosaur
reviewed
Jan 18, 2024
| @@ -69,4 +69,10 @@ else | |||
| ORCHAGENT_ARGS+="-m $MAC_ADDRESS" | |||
| fi | |||
|
|
|||
| # Enable ZMQ for SmartSwitch | |||
| LOCALHOST_SUBTYPE=`sonic-db-cli CONFIG_DB hget localhost "subtype"` | |||
There was a problem hiding this comment.
Here should be
sonic-db-cli CONFIG_DB hget "DEVICE_METADATA|localhost" "subtype"
There was a problem hiding this comment.
Thanks, I will update with new PR
Pterosaur
reviewed
Jan 18, 2024
| @@ -70,6 +70,12 @@ else | |||
| TELEMETRY_ARGS+=" -v=2" | |||
| fi | |||
|
|
|||
| # Enable ZMQ for SmartSwitch | |||
| LOCALHOST_SUBTYPE=`sonic-db-cli CONFIG_DB hget localhost "subtype"` | |||
There was a problem hiding this comment.
Thanks, I will update with new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable ZMQ on gnmi and orchagent
Why I did it
Improve GNMI API performance for Dash resources
How I did it
Modify gnmi and orchagent service start script, add ZMQ parameter.
How to verify it
Pass all UT & E2E test
Manually verify with create Dash resources via gnmi API.