Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xgs SAI version to 8.4.21.0 #16805

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Gfrom2016
Copy link
Contributor

@Gfrom2016 Gfrom2016 commented Oct 8, 2023

Why I did it

Upgrade the xgs SAI version to 8.4.21.0 to include the following changes:

  • 8.4.21.0: [CSP CS00012316669][SAI_BRANCH rel_ocp_sai_8_4] FP destroy API behavior change to avoid traffic leaks
  • 8.4.20.0: [CSP CS00012312900] Max path used as 0 in ordered ECMP replace.
  • 8.4.19.0: [CSP CS00012301679] sai_query_attribute_capability SAI_OBJECT_TYPE_SWITCH, fix few attrs in previous checkin
  • 8.4.18.0: [CSP CS00012310706] Add SAI_TUNNEL_SUPPORT to azure pipeline build files
  • 8.4.16.0: [CSP CS00012301679] sai_query_attribute_capability for obj type SAI_OBJECT_TYPE_SWITCH
  • 8.4.15.0: [SAI_BRANCH rel_ocp_sai_8_4] Port SONIC-75025 to SAI 8.4
  • 8.4.14.0: [CSP CS00012306356] Change log level of sai_bulk_object_get_stats, unsupported object type to warning
  • 8.4.13.0: [CSP CS00012302193] backport SONIC-72912 jira on SAI 8.4 branch
  • 8.4.12.0: [CSP CS00012296541][SAI_BRANCH rel_ocp_sai_8_4] Preformance improvement for ECMP from SDK-354625
  • 8.4.11.0: [CSP CS00012293985] Port SONIC-74816 fix to 8.4.
  • 8.4.10.0: [CSP NA/SID-26013][SAI_BRANCH rel_ocp_sai_8_4] SID - L3 multicast packet drop due to wrong VFI derivation - SDK-350470
  • 8.4.9.0: [CSP NA/SID-25917][SAI_BRANCH rel_ocp_sai_8_4] SID-Crash in ALPM algorithm during entry split SDK-343694
  • 8.4.8.0: [CSP CS00012275265][SAI_BRANCH rel_ocp_sai_8_4] SID Deadlock in linkscan callback during flexport operations
  • 8.4.7.0: [CSP CS00012284142] Fixed MMU buffer config issue with multicast queues
  • 8.4.6.0: [CSP CS00012275454] sai_object_type_get_availability failed with SAI_STATUS_INVALID_PARAMETER; [CSP CS00012284121] [SAI_BRANCH rel_ocp_sai_8_4] SID - L2_ENTRY Table Lookups May Miss
  • 8.4.4.0: [CSP CS00012287462] Uplift tunnel fix from SONIC-73462
  • 8.4.2.0: Fixing the issue with SAI_QUEUE_STAT_DROPPED_PACKETS retrieval; Enable/Disable bitmask for egress stats; SAI - OCP SAI 8.4 - SAI: Reduce Index data type union _brcm_sai_indexed_data_t size to be below 2k.; Cut Down Version - Port Tpid Compilation Issue Fix
Work item tracking
  • Microsoft ADO (number only): 25394693

How I did it

Upgrade the SAI version in sai.mk file.

How to verify it

Run SONiC basic test in the SAI release pipeline:
https://dev.azure.com/mssonic/internal/_build/results?buildId=381636&view=results
full qualification: https://elastictest.org/scheduler/testplan/6523b5b6f773ca326e14bffb

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
@Gfrom2016 Gfrom2016 requested a review from lguohan as a code owner October 8, 2023 06:39
@Gfrom2016
Copy link
Contributor Author

@prabhataravind I also ran a full qualification with 8.4.21.0 on 202305, the result seems fine. https://elastictest.org/scheduler/testplan/6523b5b6f773ca326e14bffb
Please help review it again, thanks.

@prabhataravind
Copy link
Contributor

@prabhataravind I also ran a full qualification with 8.4.21.0 on 202305, the result seems fine. https://elastictest.org/scheduler/testplan/6523b5b6f773ca326e14bffb Please help review it again, thanks.

@yxieca, I don't have permissions to review/merge. Could you please help approve and merge?

@yxieca yxieca merged commit 7f70632 into sonic-net:master Oct 10, 2023
9 checks passed
@yxieca
Copy link
Contributor

yxieca commented Oct 10, 2023 via email

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Oct 13, 2023
Upgrade the xgs SAI version to 8.4.21.0 to include the following changes:

8.4.21.0: [CSP CS00012316669][SAI_BRANCH rel_ocp_sai_8_4] FP destroy API behavior change to avoid traffic leaks
8.4.20.0: [CSP CS00012312900] Max path used as 0 in ordered ECMP replace.
8.4.19.0: [CSP CS00012301679] sai_query_attribute_capability SAI_OBJECT_TYPE_SWITCH, fix few attrs in previous checkin
8.4.18.0: [CSP CS00012310706] Add SAI_TUNNEL_SUPPORT to azure pipeline build files
8.4.16.0: [CSP CS00012301679] sai_query_attribute_capability for obj type SAI_OBJECT_TYPE_SWITCH
8.4.15.0: [SAI_BRANCH rel_ocp_sai_8_4] Port SONIC-75025 to SAI 8.4
8.4.14.0: [CSP CS00012306356] Change log level of sai_bulk_object_get_stats, unsupported object type to warning
8.4.13.0: [CSP CS00012302193] backport SONIC-72912 jira on SAI 8.4 branch
8.4.12.0: [CSP CS00012296541][SAI_BRANCH rel_ocp_sai_8_4] Preformance improvement for ECMP from SDK-354625
8.4.11.0: [CSP CS00012293985] Port SONIC-74816 fix to 8.4.
8.4.10.0: [CSP NA/SID-26013][SAI_BRANCH rel_ocp_sai_8_4] SID - L3 multicast packet drop due to wrong VFI derivation - SDK-350470
8.4.9.0: [CSP NA/SID-25917][SAI_BRANCH rel_ocp_sai_8_4] SID-Crash in ALPM algorithm during entry split SDK-343694
8.4.8.0: [CSP CS00012275265][SAI_BRANCH rel_ocp_sai_8_4] SID Deadlock in linkscan callback during flexport operations
8.4.7.0: [CSP CS00012284142] Fixed MMU buffer config issue with multicast queues
8.4.6.0: [CSP CS00012275454] sai_object_type_get_availability failed with SAI_STATUS_INVALID_PARAMETER; [CSP CS00012284121] [SAI_BRANCH rel_ocp_sai_8_4] SID - L2_ENTRY Table Lookups May Miss
8.4.4.0: [CSP CS00012287462] Uplift tunnel fix from SONIC-73462
8.4.2.0: Fixing the issue with SAI_QUEUE_STAT_DROPPED_PACKETS retrieval; Enable/Disable bitmask for egress stats; SAI - OCP SAI 8.4 - SAI: Reduce Index data type union _brcm_sai_indexed_data_t size to be below 2k.; Cut Down Version - Port Tpid Compilation Issue Fix

Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants