Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012][minigraph-parser] Disable unsupported counters on management devices #17351

Conversation

lizhijianrd
Copy link
Contributor

@lizhijianrd lizhijianrd commented Nov 30, 2023

Backport #16937

Why I did it
To avoid orchagent crash issue like sonic-net/sonic-swss#2935, disable unsupported counters on SONiC management devices.

Work item tracking
Microsoft ADO (number only): 25437720

How I did it
Update the minigraph parser to disable unsupported counters on management devices.

How to verify it
Verified by unittest.
Manually apply patch to DUT and do config load_minigraph

Why I did it

Work item tracking
  • Microsoft ADO (number only): 24802410

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

@lizhijianrd PR: #17351 is conflict with MS internal repo
Please complete the following PR by pushing fix commit to sonicbld/conflict_prefix/17351-fix
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9166720
Then comment "/azpw ms_conflict" to rerun PR checker.

@lizhijianrd
Copy link
Contributor Author

/azpw ms_conflict

…sonic-net#16937)

Why I did it
To avoid orchagent crash issue like sonic-net/sonic-swss#2935, disable unsupported counters on SONiC management devices.

Work item tracking
Microsoft ADO (number only): 25437720
How I did it
Update the minigraph parser to disable unsupported counters on management devices.

How to verify it
Verified by unittest.
Manually apply patch to DUT and do config load_minigraph
@lizhijianrd lizhijianrd force-pushed the backport-202012-mgmt-disable-counters branch from 61c2afa to 839c579 Compare November 30, 2023 02:52
@mssonicbld
Copy link
Collaborator

@lizhijianrd PR: #17351 is conflict with MS internal repo
Please complete the following PR by pushing fix commit to sonicbld/conflict_prefix/17351-fix
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9166971
Then comment "/azpw ms_conflict" to rerun PR checker.

@lizhijianrd
Copy link
Contributor Author

/azpw ms_conflict

@qiluo-msft qiluo-msft requested a review from Blueve December 1, 2023 18:02
@qiluo-msft qiluo-msft merged commit 2aa3298 into sonic-net:202012 Dec 4, 2023
14 checks passed
@lizhijianrd lizhijianrd deleted the backport-202012-mgmt-disable-counters branch December 5, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants