Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202305][Mellanox]: Disable MFT bash autocompletion #17359

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Nov 30, 2023

A W/A to overcome delay of about 20 sec on login due to MFT bash autocompletion bug.
Should be reverted once a formal solution will be available in future MFT release.

Why I did it

  • To overcome SN2700 20 sec delay on login
Work item tracking
  • N/A

How I did it

  • Removed MFT bash autocompletion part

How to verify it

  1. make configure PLATFORM=mellanox
  2. make target/sonic-mellanox.bin

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • 202305

Details if related

Description for the changelog

  • N/A

Link to config_db schema for YANG module changes

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@liat-grozovik liat-grozovik changed the title [202305][mellanox]: Disable MFT bash autocompletion [202305][Mellanox]: Disable MFT bash autocompletion Dec 3, 2023
@nazariig nazariig marked this pull request as ready for review December 4, 2023 20:10
@nazariig nazariig requested a review from lguohan as a code owner December 4, 2023 20:10
@StormLiangMS
Copy link
Contributor

hi @qiluo-msft could you have some expert help to review?

@qiluo-msft qiluo-msft requested a review from liuh-80 December 5, 2023 19:29
@liat-grozovik
Copy link
Collaborator

@StormLiangMS please assist with merge

@dgsudharsan
Copy link
Collaborator

@StormLiangMS Tested on top of 202305 commit 2b8efdb

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 06ed67d into sonic-net:202305 Dec 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants