[action] [PR:17253] [Arista] Use port_config.ini for Arista-7050QX-32S-S4Q31 #17574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7253) This change of removing hwsku.json is to correct the port index for sfp ports (Ethernet0, Ethernet1, Ethernet2, Ethernet3) by using port_config.ini, which should be '1, 2, 3, 4'. We could not do it with hwsku.json, as it is defined as '5, 5, 5, 5' by platform.json for the breakout_mode 1x40G[10G].
11 tasks
|
Original PR: #17253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This change of removing hwsku.json is to correct the port index for SFP ports (Ethernet0, Ethernet1, Ethernet2, Ethernet3) by using port_config.ini, which should be '1, 2, 3, 4'. We could not do it with hwsku.json, as it has been defined as '5, 5, 5, 5' in platform.json, which is correct for the breakout_mode 1x40G[10G]: https://github.com/sonic-net/sonic-buildimage/blob/master/device/arista/x86_64-arista_7050_qx32s/platform.json#L215. The port index is used by xcvr-related operations like sfputil.
Work item tracking
How I did it
How to verify it
Checked that port speed is correct after sanitize
Ethernet0 9 10G 9100 N/A Ethernet1 routed down down N/A off
Ethernet1 10 10G 9100 N/A Ethernet2 routed down down N/A off
Ethernet2 11 10G 9100 N/A Ethernet3 routed down down N/A off
Ethernet3 12 1G 9100 N/A Ethernet4 routed down down N/A off
Ethernet4 13,14,15,16 40G 9100 N/A Ethernet6/1 routed down down QSFP+ or later with SFF-8636 or SFF-8436 off
Ethernet8 17,18,19,20 40G 9100 N/A Ethernet7/1 routed down down QSFP+ or later with SFF-8636 or SFF-8436 off
Ethernet12 21,22,23,24 40G 9100 N/A Ethernet8/1 routed down down N/A off in
Checked that port index is correct after sanitize
sonic-db-cli APPL_DB hgetall PORT_TABLE:Ethernet0
{'alias': 'Ethernet1', 'description': 'Ethernet1', 'index': '1', 'lanes': '9', 'mtu': '9100', 'pfc_asym': 'off', 'speed': '10000', 'tpid': '0x8100', 'admin_status': 'down', 'oper_status': 'down'}
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)