-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nvidia] [202205] Update syncd docker to use python version 3 #17733
Conversation
This reverts commit c4e3445.
Signed-off-by: liorghub <liora@nvidia.com>
@yxieca , Can you please approve and merge ? |
@yxieca The initial plan was to remove python2 from Nvidia syncd container, but then I saw that Python2 exists in RPC container therefore I handled RPC container as well. |
@yxieca , Python2 is deprecated from NVIDIA (Mellanox) syncd so it was removed. This is the reason for this PR. |
@liorghub @dprital I fully support removing python2 code. However, I don't think we should do it in 202205 at this point when qualification activity is done or almost done. This change can go to newer branches. |
@yxieca , OK. This is the PR for Master (and request to cherry pick to 202305 and 202311). Can you please Approve and merge ? |
Why I did it
Python 2 is obsolete and no longer supported.
Work item tracking
How I did it
Change several packages installation commands in Nvidia syncd dockerfile to Python3 packages.
Change was done for regular image and for RPC image as well.
How to verify it
I tested several SDK API scripts manually (while all others are tested by SDK verification) and ran regression tests that run on RPC version.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)