-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swss/syncd]: Remove dependency on interfaces-config.service #17739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
10 tasks
nazariig
requested review from
liat-grozovik,
volodymyrsamotiy,
stepanblyschak and
StormLiangMS
January 10, 2024 13:19
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@yxieca to signoff/merge |
yxieca
approved these changes
Jan 18, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jan 31, 2024
…et#17739) Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> Co-authored-by: Stepan Blyshchak <38952541+stepanblyschak@users.noreply.github.com>
Cherry-pick PR to 202311: #17964 |
10 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Feb 1, 2024
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> Co-authored-by: Stepan Blyshchak <38952541+stepanblyschak@users.noreply.github.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Feb 1, 2024
Hi @nazariig, 202305 is done, any justification for necessary to pick up this? |
@StormLiangMS it is already in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
This improvement does not bring any warm-reboot degradation, since the database availability (tcp/ip access over the loopback interface) was fixed by these PRs:
Why I did it
interfaces-config.service
to speed up the boot, becauseinterfaces-config.service
takes a lot of time on initWork item tracking
How I did it
swss
/syncd
How to verify it
swss
/syncd
start time comparing tointerfaces-config
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)