Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add locator func to frrcfgd #20330

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

Yubin-Li
Copy link
Contributor

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: ysj17861081006 <1686637505@qq.com>
@Yubin-Li Yubin-Li requested a review from lguohan as a code owner September 23, 2024 06:43
Copy link

linux-foundation-easycla bot commented Sep 23, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Yubin-Li (01cb78a)
  • ✅ login: ysj17861081006 / name: Patrick (40be3e3)

@eddieruan-alibaba
Copy link
Collaborator

Has cherry-picked in Phoenixwing

eddieruan-alibaba@ae030c3

@@ -401,6 +402,47 @@ def get_command_cmn(daemon, cmd_str, op, st_idx, vals, bool_values):
cmd_args.append(CommandArgument(daemon, cmd_enable, vals[idx]))
return [cmd_str.format(*cmd_args, no = CommandArgument(daemon, cmd_enable))]

def hdl_srv6_locator(daemon, cmd_str, op, st_idx, vals, bool_values):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no unit tests at all?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/eddieruan-alibaba/sonic-mgmt/blob/eruan-testcasemaster/ansible/vars/configdb_jsons/7nodes_cisco/PE1.json#L8

in sonic-net/sonic-mgmt#13785

Result could be found at https://aisportal.oss-cn-hangzhou.aliyuncs.com/phoenixwing/log/basesanity/basesanity_242_log.tar

Test results sneak view.

srv6/test_srv6_basic_sanity.py::test_interface_on_each_node PASSED [ 14%]
srv6/test_srv6_basic_sanity.py::test_check_bgp_neighbors PASSED [ 28%]
srv6/test_srv6_basic_sanity.py::test_check_routes PASSED [ 42%]
srv6/test_srv6_basic_sanity.py::test_traffic_check PASSED [ 57%]
srv6/test_srv6_basic_sanity.py::test_traffic_check_local_link_fail_case PASSED [ 71%]
srv6/test_srv6_basic_sanity.py::test_traffic_check_remote_igp_fail_case PASSED [ 85%]
srv6/test_srv6_basic_sanity.py::test_traffic_check_remote_bgp_fail_case PASSED [100%]

@eddieruan-alibaba
Copy link
Collaborator

@lguohan @kperumalbfn Need help to review this PR.

@lguohan lguohan merged commit 174d726 into sonic-net:master Nov 15, 2024
21 checks passed
aidan-gallagher pushed a commit to aidan-gallagher/sonic-buildimage that referenced this pull request Nov 16, 2024
Signed-off-by: ysj17861081006 <1686637505@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants