Update the copp test rate limits for queue4_group3 #10724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not update default sonic config for queue4_group3 in scripts/update_copp_config.py as the new rate-limit for this copp group is lower than the default value of 600 PPS used by copp tests * Change constraint checks to reflect a rate-limit of 300 PPS for queue4_group3 in ansible/roles/test/files/ptftests/py3/copp_tests.py Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
…00 PPS * This is necessary to prevent BGP/LACP protocol flaps in certain scenarios there is a flood of DHCP broadcast packets. Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
prsunny
approved these changes
Nov 16, 2023
|
Cisco-8111 platform seems to have an issue which will cause it to fail this test once this PR is merged, so waiting to confirm with Cisco before merging this change in. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Do not update default sonic config for queue4_group3 in scripts/update_copp_config.py as the new rate-limit for this copp group is lower than the default value of 600 PPS used by copp tests
Change constraint checks to reflect a rate-limit of 100 PPS for queue4_group3 in ansible/roles/test/files/ptftests/py3/copp_tests.py
This sonic-mgmt change is dependent on and should be merged only after the following buildimage change is merged:
[image_config]: Update DHCP rate-limit sonic-buildimage#17132
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
DHCP/LLDP/UDLD are rate-limited at 100 PPS via SONiC copp configuration, so the test should also test at that limit.
How did you do it?
By changing the default PPS for DHCP/UDLD/LLDP in copp tests to be 100 PPS
How did you verify/test it?
By running copp tests and making sure DHCP/UDLD/LLDP are rate-limited at 100 PPS.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation