Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202305] Revert LPM test due to design change back and fix some LPM test issue #10902

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

JibinBao
Copy link
Contributor

@JibinBao JibinBao commented Nov 30, 2023

Description of PR

Summary:

  1. Revert LPM test, because the implementation has been reverted to the old way.[Mellanox] Revert LPM implementation to the old way sonic-buildimage#17096
  2. Fix issue of test_check_sfputil_low_power_mode. Previously after setting the lpmode, test checks the value is on or off, which is not correct. we should check if the value of lpmode is the set one.
  3. When the cable type is OSPF and the power class is not "Power Class 1", it also supports LPM. So, add a check accordingly.

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

Revert lpm test

How did you do it?

Revert lpm test

How did you verify/test it?

Run lmp test on image inlcuding sonic-net/sonic-buildimage#17096

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

When setting lpm, we need to check it is changed to the corresponding mode, not just check lpm is on o off.

Change-Id: I97ac5818d57c4ae15be3dbee7dae4878a95f8b2c
Fix lpm test, we just need to check the interface supporting ldp instead of all interfaces

Change-Id: I5eeed28de626202b6eb43c8f7e622b3dc5c22751
@JibinBao JibinBao requested a review from prgeor as a code owner November 30, 2023 02:44
@JibinBao JibinBao changed the title [202305] Revert lpm 202305 [202305] Revert lpm test Nov 30, 2023
@JibinBao JibinBao changed the title [202305] Revert lpm test [202305] Revert LPM test due to design change back Nov 30, 2023
@liat-grozovik
Copy link
Collaborator

if you cannot take the master PR to 202305 with clean cherrypick can you please refer to the master PR for tracking?
also does not seems it is only revert. can you explain the motivation of the fix and the additional changes done?

@JibinBao
Copy link
Contributor Author

JibinBao commented Dec 8, 2023

if you cannot take the master PR to 202305 with clean cherrypick can you please refer to the master PR for tracking? also does not seems it is only revert. can you explain the motivation of the fix and the additional changes done?

@liat-grozovik .
Thank you for your comments.

  1. master PR: Revert LPM test due to design change back and fix some LPM test issues #10903
  2. I have updated the description.

@JibinBao JibinBao changed the title [202305] Revert LPM test due to design change back [202305] Revert LPM test due to design change back and fix some LPM test issue Dec 8, 2023
@liat-grozovik
Copy link
Collaborator

@yxieca can you please help to merge to release branch?

@yxieca yxieca merged commit 668c46d into sonic-net:202305 Dec 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants