Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202205][Ansible] Skip package migrate when installing image (#13721) #13791

Closed
wants to merge 1 commit into from

Conversation

yaqiangz
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Manually cherry-pick and resolve conflict of this PR: #13721
Currently install image in sonic-mgmt is use default param, which would migrate sonic-extension-application package by default (dhcp_relay, macsec, dhcp_server) when install to a os version which doesn't contain them. This is un-clean install, should be fixed. Also, there is an issue with sonic_package_manager when migrate package sonic-net/sonic-buildimage#19633

How did you do it?

When installing image, check whether it support skip-package-migrate, if so, skip it.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR?
Currently install image in sonic-mgmt is use default param, which would migrate sonic-extension-application package by default (dhcp_relay, macsec, dhcp_server) when install to a os version which doesn't contain them. This is un-clean install, should be fixed.
Also, there is an issue with sonic_package_manager when migrate package sonic-net/sonic-buildimage#19633

How did you do it?
When installing image, check whether it support skip-package-migrate, if so, skip it.

How did you verify/test it?
Use .azure-pipelines/upgrade_image.py to install image from os support package migrate and not support package migrate to a new version, no error
@yaqiangz
Copy link
Contributor Author

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants