Added skip for test_mgmt_ipv6_only TC if ipv6 mgmt not available #14273
Conversation
SavchukRomanLv
force-pushed
the
skip_test_mgmt_ipv6
branch
from
6d0a2bd to
205eaff
Compare
| pytest.skip(f"{duthost.hostname} doesn't have available IPv6 Management IP address") | ||
|
|
||
| if not ipv6_address[duthost.hostname]: | ||
| pytest.skip(f"{duthost.hostname} doesn't have IPv6 Management IP address") |
There was a problem hiding this comment.
Can you elaborate on why reordering these 2 conditions?
If we do have assigned IPv6 address but not configured on the mgmt port, should this be a failure or skip?
There was a problem hiding this comment.
Hi @yxieca for me it still setup issue and not TC issue, so I'd prefer skip rather than fail. How do you think?
There was a problem hiding this comment.
@SavchukRomanLv I think Ying's question is why you check has_available_ipv6_addr before ipv6_address. Is there a particular reason for changing the order?
There was a problem hiding this comment.
Hi @bingwang-ms - I got you, returned order as it was before, I've accidentally changed it
There was a problem hiding this comment.
@bingwang-ms I must do additional changes not related to my PR to pass flake issues:
seems like flake also does analysis of f strings:
tests/common/fixtures/duthost_utils.py:846:36: E713 test for membership should be 'not in'
tests/common/fixtures/duthost_utils.py:851:34: E713 test for membership should be 'not in'
should it work in such way?
SavchukRomanLv
force-pushed
the
skip_test_mgmt_ipv6
branch
from
205eaff to
fe97526
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SavchukRomanLv
force-pushed
the
skip_test_mgmt_ipv6
branch
from
fe97526 to
d9b127f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description of PR
Summary:
Fixes failure if DUT does not have ipv6 management address set
Type of change
Back port request
Approach
What is the motivation for this PR?
If DUT does not have ipv6 mgmt address to be set - TC fails
How did you do it?
Add pytest.skip if ipv6 mgmt address not set
How did you verify/test it?
Run TC. TC skip
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation