[deploy-mg] Disable default_pfcwd_status for m0/mx #15922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blueve
approved these changes
Dec 9, 2024
|
Hi @wangxin could you please help to merge this PR? |
wangxin
approved these changes
Dec 10, 2024
|
Hi @bingwang-ms , could you please help to approve the backport request? |
|
@yaqiangz PR conflicts with 202405 branch |
|
@yaqiangz Please raise another PR to 202405 to fix the conflict. |
yaqiangz
added a commit
to yaqiangz/sonic-mgmt
that referenced
this pull request
Dec 11, 2024
What is the motivation for this PR? default_pfcwd_status should be disable for m0 and mx How did you do it? In golden config_db, disable pfcwd for m0 and mx How did you verify/test it? Deploy topo
8 tasks
bingwang-ms
pushed a commit
that referenced
this pull request
Dec 11, 2024
8 tasks
wangxin
pushed a commit
that referenced
this pull request
Dec 17, 2024
…rsion doesn't support dhcp_server (#16086) What is the motivation for this PR? Golden config db var has been changed from json like string to dict by this RP #15922 But for mx with OS version doesn't support dhcp_server, it would still generate empty json like string, which would cause failure How did you do it? Change empty golden config generated for mx doesn't support dhcp_server How did you verify/test it? Deploy-mg
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 17, 2024
…rsion doesn't support dhcp_server (sonic-net#16086) What is the motivation for this PR? Golden config db var has been changed from json like string to dict by this RP sonic-net#15922 But for mx with OS version doesn't support dhcp_server, it would still generate empty json like string, which would cause failure How did you do it? Change empty golden config generated for mx doesn't support dhcp_server How did you verify/test it? Deploy-mg
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 30, 2024
…rsion doesn't support dhcp_server (#16086) What is the motivation for this PR? Golden config db var has been changed from json like string to dict by this RP #15922 But for mx with OS version doesn't support dhcp_server, it would still generate empty json like string, which would cause failure How did you do it? Change empty golden config generated for mx doesn't support dhcp_server How did you verify/test it? Deploy-mg
yaqiangz
added
Included in 202405 branch
Approved for 202411 branch
and removed
Cherry Pick Conflict_202405
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 31, 2024
What is the motivation for this PR? default_pfcwd_status should be disable for m0 and mx How did you do it? In golden config_db, disable pfcwd for m0 and mx How did you verify/test it? Deploy topo
|
Cherry-pick PR to 202411: #16261 |
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 31, 2024
…rsion doesn't support dhcp_server (sonic-net#16086) What is the motivation for this PR? Golden config db var has been changed from json like string to dict by this RP sonic-net#15922 But for mx with OS version doesn't support dhcp_server, it would still generate empty json like string, which would cause failure How did you do it? Change empty golden config generated for mx doesn't support dhcp_server How did you verify/test it? Deploy-mg
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 31, 2024
…rsion doesn't support dhcp_server (#16086) What is the motivation for this PR? Golden config db var has been changed from json like string to dict by this RP #15922 But for mx with OS version doesn't support dhcp_server, it would still generate empty json like string, which would cause failure How did you do it? Change empty golden config generated for mx doesn't support dhcp_server How did you verify/test it? Deploy-mg
mssonicbld
pushed a commit
that referenced
this pull request
Dec 31, 2024
What is the motivation for this PR? default_pfcwd_status should be disable for m0 and mx How did you do it? In golden config_db, disable pfcwd for m0 and mx How did you verify/test it? Deploy topo
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
default_pfcwd_status should be
disablefor m0 and mxHow did you do it?
In golden config_db, disable pfcwd for m0 and mx
How did you verify/test it?
Deploy topo
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation