-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add symbolic link for t0-isolated-d128u128s1-leaf.j2 in ansible templates #16094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janetxxx <janet970527@gmail.com>
Signed-off-by: Janetxxx <janet970527@gmail.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
approved these changes
Dec 17, 2024
/azp run |
Commenter does not have sufficient privileges for PR 16094 in repo sonic-net/sonic-mgmt |
Signed-off-by: Janetxxx <janet970527@gmail.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Dec 18, 2024
bingwang-ms
reviewed
Dec 18, 2024
@@ -217,6 +217,6 @@ def _config_reload_cmd_wrapper(cmd, executable): | |||
if wait_for_bgp: | |||
bgp_neighbors = sonic_host.get_bgp_neighbors_per_asic(state="all") | |||
pytest_assert( | |||
wait_until(wait + 120, 10, 0, sonic_host.check_bgp_session_state_all_asics, bgp_neighbors), | |||
wait_until(wait + 300, 10, 0, sonic_host.check_bgp_session_state_all_asics, bgp_neighbors), | |||
"Not all bgp sessions are established after config reload", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the wait time when calling this function instead of changing the default wait time?
8 tasks
8 tasks
Janetxxx
changed the title
Add symbolic link for t0-isolated-d128u128s2-leaf.j2 in ansible templates
Add symbolic link for t0-isolated-d128u128s1-leaf.j2 in ansible templates
Dec 24, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 24, 2024
…ates (sonic-net#16094) What is the motivation for this PR? Unable to find 't0-isolated-d128u128s1-leaf.j2' when running add-topo How did you do it? Add symbolic link for t0-isolated-d128u128s1-leaf.j2 How did you verify/test it? Running add-topo to verify it Signed-off-by: Janetxxx <janet970527@gmail.com>
Cherry-pick PR to 202405: #16221 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 24, 2024
…ates (#16094) What is the motivation for this PR? Unable to find 't0-isolated-d128u128s1-leaf.j2' when running add-topo How did you do it? Add symbolic link for t0-isolated-d128u128s1-leaf.j2 How did you verify/test it? Running add-topo to verify it Signed-off-by: Janetxxx <janet970527@gmail.com>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Unable to find 't0-isolated-d128u128s1-leaf.j2' when running add-topo
How did you do it?
Add symbolic link for t0-isolated-d128u128s1-leaf.j2
How did you verify/test it?
Running add-topo to verify it
Any platform specific information?
str4-sn5600-1
Supported testbed topology if it's a new test case?
t0-isolated-d128u128s1
Documentation