Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbolic link for t0-isolated-d128u128s1-leaf.j2 in ansible templates #16094

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

Janetxxx
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Unable to find 't0-isolated-d128u128s1-leaf.j2' when running add-topo

How did you do it?

Add symbolic link for t0-isolated-d128u128s1-leaf.j2

How did you verify/test it?

Running add-topo to verify it

Any platform specific information?

str4-sn5600-1

Supported testbed topology if it's a new test case?

t0-isolated-d128u128s1

Documentation

Signed-off-by: Janetxxx <janet970527@gmail.com>
Signed-off-by: Janetxxx <janet970527@gmail.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Janetxxx Janetxxx requested a review from Pterosaur December 16, 2024 23:34
@Janetxxx
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 16094 in repo sonic-net/sonic-mgmt

Signed-off-by: Janetxxx <janet970527@gmail.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin wangxin merged commit 6860828 into sonic-net:master Dec 18, 2024
16 checks passed
@@ -217,6 +217,6 @@ def _config_reload_cmd_wrapper(cmd, executable):
if wait_for_bgp:
bgp_neighbors = sonic_host.get_bgp_neighbors_per_asic(state="all")
pytest_assert(
wait_until(wait + 120, 10, 0, sonic_host.check_bgp_session_state_all_asics, bgp_neighbors),
wait_until(wait + 300, 10, 0, sonic_host.check_bgp_session_state_all_asics, bgp_neighbors),
"Not all bgp sessions are established after config reload",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the wait time when calling this function instead of changing the default wait time?

@Janetxxx Janetxxx changed the title Add symbolic link for t0-isolated-d128u128s2-leaf.j2 in ansible templates Add symbolic link for t0-isolated-d128u128s1-leaf.j2 in ansible templates Dec 24, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Dec 24, 2024
…ates (sonic-net#16094)

What is the motivation for this PR?
Unable to find 't0-isolated-d128u128s1-leaf.j2' when running add-topo

How did you do it?
Add symbolic link for t0-isolated-d128u128s1-leaf.j2

How did you verify/test it?
Running add-topo to verify it

Signed-off-by: Janetxxx <janet970527@gmail.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #16221

mssonicbld pushed a commit that referenced this pull request Dec 24, 2024
…ates (#16094)

What is the motivation for this PR?
Unable to find 't0-isolated-d128u128s1-leaf.j2' when running add-topo

How did you do it?
Add symbolic link for t0-isolated-d128u128s1-leaf.j2

How did you verify/test it?
Running add-topo to verify it

Signed-off-by: Janetxxx <janet970527@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants