-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safe_reload and interface check for process monitoring and container check tests #16252
Merged
yejianquan
merged 2 commits into
sonic-net:master
from
yejianquan:jianquanye/fix_flakyness
Dec 28, 2024
Merged
Add safe_reload and interface check for process monitoring and container check tests #16252
yejianquan
merged 2 commits into
sonic-net:master
from
yejianquan:jianquanye/fix_flakyness
Dec 28, 2024
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring and container check tests
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
FYI @bingwang-ms , the failure has a high chance to be reproduced on 202405 branch |
lerry-lee
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Dec 27, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 28, 2024
…ner check tests (sonic-net#16252) Description of PR Summary: Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. Approach What is the motivation for this PR? Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console How did you do it? Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. How did you verify/test it? PR test will verify it. authorized by: jianquanye@microsoft.com
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 28, 2024
…ner check tests (sonic-net#16252) Description of PR Summary: Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. Approach What is the motivation for this PR? Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console How did you do it? Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. How did you verify/test it? PR test will verify it. authorized by: jianquanye@microsoft.com
Cherry-pick PR to 202405: #16257 |
Cherry-pick PR to 202411: #16258 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 28, 2024
…ner check tests (#16252) Description of PR Summary: Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. Approach What is the motivation for this PR? Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console How did you do it? Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. How did you verify/test it? PR test will verify it. authorized by: jianquanye@microsoft.com
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Dec 28, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Dec 29, 2024
…ner check tests (#16252) Description of PR Summary: Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. Approach What is the motivation for this PR? Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console How did you do it? Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. How did you verify/test it? PR test will verify it. authorized by: jianquanye@microsoft.com
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Notice quite a lot flaky failures on PR test,
https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console
Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy.
Type of change
Back port request
Approach
What is the motivation for this PR?
Notice quite a lot flaky failures on PR test,
https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console
How did you do it?
Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy.
How did you verify/test it?
PR test will verify it.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation