Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dualtor] Fix testFdbMacLearning #16549

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Jan 16, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

testFdbMacLearning is flaky on dualtor.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?

Let's toggle the mux ports to the random selected DUT, so all packets will be forwarded to it.

How did you verify/test it?

fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testFdbMacLearning PASSED                                                                                                                                                                                            [100%]

================================================================================================================= 1 passed, 3 warnings in 1558.19s (0:25:58) =================================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingwang-ms bingwang-ms merged commit 3e50c08 into sonic-net:master Jan 16, 2025
22 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 16, 2025
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #16555

mssonicbld pushed a commit that referenced this pull request Jan 16, 2025
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
yejianquan pushed a commit to yejianquan/sonic-mgmt that referenced this pull request Jan 17, 2025
These changes are picked up in this merge

c74b051 (upstream/202405) Fix the test_nhop_group nexthop map for ld DUTs (sonic-net#16166)
3850e85 [dualtor] Fix `testFdbMacLearning` (sonic-net#16549)
4c5b264 Stabilize `test_snmp_fdb_send_tagged` (sonic-net#16409)
9b999f7 Fix ASIC check in test_pfcwd_function (sonic-net#16535) (sonic-net#16539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants