[Impacted Area Based PR testing] Roll out rest of the PR checkers #16565
+171
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/roll_out_all_checkers
branch
from
a356ed8 to
3cd1ced
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/roll_out_all_checkers
branch
from
3cd1ced to
f1cdc14
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/roll_out_all_checkers
branch
from
b33d3d7 to
f0635ec
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/roll_out_all_checkers
branch
from
619d7ba to
122bf05
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lerry-lee
reviewed
Jan 17, 2025
azure-pipelines.yml
Outdated
| - job: impacted_area_t0_2vlans_elastictest | ||
| displayName: "impacted-area-kvmtest-t0_2vlans by Elastictest - optional" | ||
| dependsOn: get_impacted_area | ||
| condition: contains(dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS'], '2vlans') |
There was a problem hiding this comment.
“eq” is used to determine whether two strings are equal. In our case, we need to determine whether one string contains another string or one string in another string. As the value dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS'] only can be a string, so we refrain from using overlapping string
There was a problem hiding this comment.
As we discussed, we will add a suffix for t0 and t1.
yutongzhang-microsoft
force-pushed
the
yutongzhang/roll_out_all_checkers
branch
from
122bf05 to
c37676c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/roll_out_all_checkers
branch
from
8c41cab to
fbf1745
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/roll_out_all_checkers
branch
from
a470ed2 to
0b6d1aa
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
changed the title
wangxin
previously approved these changes
Jan 17, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/roll_out_all_checkers
branch
from
07d6c24 to
53ed317
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In #15666, we introduced a new approach to PR testing called Impacted Area-Based PR Testing. This model will be rolled out in phases. This PR implement the left PR checkers.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In #15666, we introduced a new approach to PR testing called Impacted Area-Based PR Testing. This model will be rolled out in phases. This PR implement the left PR checkers.
How did you do it?
Roll out the left PR checkers.
How did you verify/test it?
Test by pipeline itself, to see if PR checkers are running as expected.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation