add if statement for module control mode support #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarashinvd
changed the title
kcudnik
approved these changes
Oct 26, 2023
|
Please add description |
thanks. I did. |
|
PR is draft. |
kcudnik
approved these changes
Nov 8, 2023
prgeor
approved these changes
Nov 14, 2023
|
is this still a draft or can be merged ? |
|
@kcudnik can you please help to merge this PR? |
dbarashinvd
added a commit
to dbarashinvd/sonic-sairedis
that referenced
this pull request
Jan 23, 2024
)" This reverts commit 45cbf14.
kcudnik
pushed a commit
that referenced
this pull request
Jan 29, 2024
Reverts #1305 this logic is not needed. we'll change sai.profile directly
mssonicbld
pushed a commit
to mssonicbld/sonic-sairedis
that referenced
this pull request
Jan 31, 2024
…1341) Reverts sonic-net#1305 this logic is not needed. we'll change sai.profile directly
mssonicbld
pushed a commit
that referenced
this pull request
Feb 11, 2024
Reverts #1305 this logic is not needed. we'll change sai.profile directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Feature - CMIS management
Work item tracking
How I did it
update syncd init common script to add module control profile content into sai.profile file
How to verify it
manually check sai.profile on a supporting switch (MSFT SKU) and verify module control profile content in it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)