[vslib] SAI_KEY_VS_OPER_SPEED_IS_CONFIGURED_SPEED, SAI_PORT_ATTR_HOST_TX_READY_STATUS support #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kcudnik
reviewed
Nov 11, 2024
kcudnik
reviewed
Nov 11, 2024
ishidawataru
force-pushed
the
vslib-oper-speed-is-configured-speed
branch
2 times, most recently
from
5108c19 to
75fcfc2
Compare
kcudnik
previously approved these changes
Nov 14, 2024
Signed-off-by: Wataru Ishida <wataru.ishid@gmail.com>
Signed-off-by: Wataru Ishida <wataru.ishid@gmail.com>
Signed-off-by: Wataru Ishida <wataru.ishid@gmail.com>
ishidawataru
force-pushed
the
vslib-oper-speed-is-configured-speed
branch
from
9d0654e to
93f6805
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kcudnik I have addressed the review comments and rebased onto the master branch. Could you please take a look again? |
kcudnik
approved these changes
Dec 12, 2024
|
@kcudnik Thank you for approving the PR. Could you also merge this? I'm planning to open another PR in the sonic-buildimage repo and want to include this fix in it. |
|
There are 4 pr which were reverted on master in buldimage because broadcom issues, can we wait to next week after that we will be reverted to avoid conlicts |
|
@kcudnik sure, no problem. Thank you for letting me know. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two features to
vslib.SAI_KEY_VS_OPER_SPEED_IS_CONFIGURED_SPEED: whentrue,SAI_PORT_ATTR_SPEEDreturns the configured speed instead of the value retrieved via/sys/class/net/<name>/speed.SAI_PORT_ATTR_HOST_TX_READY_STATUS: always returnstrue. Required to support runningxcvrdin the VS env.