Add more information when connect redis fail #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenxs
approved these changes
Jun 7, 2024
Junchao-Mellanox
force-pushed
the
master-clear-reason
branch
2 times, most recently
from
eadf646
to
1f627e1
Compare
dgsudharsan
approved these changes
Jun 12, 2024
|
/azpw run Azure.sonic-swss-common |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss-common |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss-common |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss-common |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
force-pushed
the
master-clear-reason
branch
from
24e0d49
to
6d6bd2d
Compare
|
/azpw run Azure.sonic-swss-common |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss-common |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @prsunny , could you please review and merge? |
|
@qiluo-msft could you please help to review or suggest another reviewer? |
liat-grozovik
approved these changes
Oct 20, 2024
|
@qiluo-msft Can you please help review? |
|
@qiluo-msft Kindly remind. Can you help review? |
mssonicbld
pushed a commit
to mssonicbld/sonic-swss-common
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Liat Grozovik <44433539+liat-grozovik@users.noreply.github.com> Co-authored-by: Guohan Lu <lguohan@gmail.com>
|
Cherry-pick PR to 202405: #951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did this?
Make it clear that why redis connect fail
How I did this?
Add error message and error code when redis connection failed
How I verify this?
Manual test
sonic-mgmt regression