Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common] enable redispipeline to only publish after flush #895

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

a114j0y
Copy link
Contributor

@a114j0y a114j0y commented Jul 22, 2024

What I did

  • optimize redispipeline flush performance by remove unnecessary publish commands
  • add a new parameterbool flushPub in producerstatetable constructor function
    • to enable/disable batch publish feature
    • default value of m_flushPub is false, so no impact on existing codes
    • optimization is effective only explicitly set this option
  • remove individual publish command from the producerstatetable APIs' lua scripts
  • add a publish command when the pipeline flushes [if m_flushPub is true]

Why I did it

  • save TCP traffic and increase fpmsyncd efficiency

It's a feature included in BGP Loading Optimization HLD #1521 GitHub issue/pull request detail

common/Makefile.am Outdated Show resolved Hide resolved
common/redispipeline.h Outdated Show resolved Hide resolved
liuh-80
liuh-80 previously approved these changes Oct 8, 2024
@a114j0y a114j0y force-pushed the flushpub branch 2 times, most recently from f3813b5 to c98db95 Compare October 8, 2024 17:17
@a114j0y a114j0y force-pushed the flushpub branch 3 times, most recently from 3f33a98 to 6fc97f9 Compare October 22, 2024 23:44
@deepak-singhal0408
Copy link

/azpw run Azure.sonic-swss-common

@deepak-singhal0408
Copy link

/azp run Azure.sonic-swss-common

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@a114j0y a114j0y force-pushed the flushpub branch 4 times, most recently from 1891c61 to bb7155a Compare October 31, 2024 23:57
@a114j0y a114j0y force-pushed the flushpub branch 2 times, most recently from 641fd83 to 2d8b19b Compare November 1, 2024 22:07
@eddieruan-alibaba
Copy link

@liuh-80 do you have further comments?

@a114j0y a114j0y force-pushed the flushpub branch 4 times, most recently from 34083c4 to fb3a9c5 Compare November 6, 2024 22:43
liuh-80
liuh-80 previously approved these changes Nov 8, 2024
@a114j0y
Copy link
Contributor Author

a114j0y commented Nov 8, 2024

just rebased on upstream/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants