-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common] enable redispipeline to only publish after flush #895
Open
a114j0y
wants to merge
5
commits into
sonic-net:master
Choose a base branch
from
eddieruan-alibaba:flushpub
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a114j0y
force-pushed
the
flushpub
branch
2 times, most recently
from
August 25, 2024 23:31
81ee88f
to
3ef9655
Compare
liuh-80
reviewed
Aug 26, 2024
liuh-80
reviewed
Aug 26, 2024
liuh-80
reviewed
Aug 26, 2024
liuh-80
reviewed
Aug 26, 2024
liuh-80
reviewed
Aug 26, 2024
a114j0y
force-pushed
the
flushpub
branch
6 times, most recently
from
August 30, 2024 21:57
5c0a375
to
d033f37
Compare
a114j0y
force-pushed
the
flushpub
branch
6 times, most recently
from
September 24, 2024 00:31
65cba5f
to
1d27f30
Compare
a114j0y
force-pushed
the
flushpub
branch
4 times, most recently
from
October 7, 2024 23:40
d2cb95f
to
a3bd808
Compare
liuh-80
reviewed
Oct 8, 2024
liuh-80
previously approved these changes
Oct 8, 2024
a114j0y
force-pushed
the
flushpub
branch
2 times, most recently
from
October 8, 2024 17:17
f3813b5
to
c98db95
Compare
a114j0y
force-pushed
the
flushpub
branch
3 times, most recently
from
October 22, 2024 23:44
3f33a98
to
6fc97f9
Compare
/azpw run Azure.sonic-swss-common |
/azp run Azure.sonic-swss-common |
Azure Pipelines successfully started running 1 pipeline(s). |
a114j0y
force-pushed
the
flushpub
branch
4 times, most recently
from
October 31, 2024 23:57
1891c61
to
bb7155a
Compare
liuh-80
reviewed
Nov 1, 2024
a114j0y
force-pushed
the
flushpub
branch
2 times, most recently
from
November 1, 2024 22:07
641fd83
to
2d8b19b
Compare
@liuh-80 do you have further comments? |
a114j0y
force-pushed
the
flushpub
branch
4 times, most recently
from
November 6, 2024 22:43
34083c4
to
fb3a9c5
Compare
liuh-80
previously approved these changes
Nov 8, 2024
just rebased on upstream/master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
bool flushPub
inproducerstatetable
constructor functionm_flushPub
isfalse
, so no impact on existing codesproducerstatetable
APIs' lua scriptsm_flushPub
istrue
]Why I did it
It's a feature included in BGP Loading Optimization HLD #1521