[orchagent]: VXLAN: Fix oper_status and tunnel encapsulation TTL #3383

bradh352 · 2024-11-20T14:41:02Z

What I did

This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk.

The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible:

# show vxlan remotevtep
+------------+------------+-------------------+--------------+
| SIP        | DIP        | Creation Source   | OperStatus   |
+============+============+===================+==============+
| 172.16.0.1 | 172.16.0.2 | EVPN              | oper_down    |
+------------+------------+-------------------+--------------+
Total count : 1

The remote VTEP is really up.

Original PR for that is #2080.

Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging.

The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is #3216, however it appears it has its origins in
sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3

Why I did it

Fixes #3216
Fixes #2080
Fixes sonic-net/sonic-buildimage#10050
Fixes sonic-net/sonic-buildimage#10004

How I verified it

Pulled into my private sonic-swss fork:
https://github.com/bradh352/sonic-swss/commits/bradh352/master

Which is pulled in by my private sonic-buildimage fork:
https://github.com/bradh352/sonic-buildimage/tree/bradh352/master

Which is then automatically built when changes are made. Then the uploaded asset of sonic-broadcom.bin is installed onto Dell S5248F switches and tested.

Update: also now tested by me on Mellanox/NVidia SN2201

Details if related

Signed-off-by: Brad House (@bradh352)

This should also be backported to 202411, 202405

linux-foundation-easycla · 2024-11-20T14:41:22Z

The committers listed above are authorized under a signed CLA.

✅ login: bradh352 / name: Brad House (bc528b6, 74238d1, 4149ce5, f461115)

VladimirKuk

Looks good to me

bradh352 · 2024-11-20T20:34:31Z

@VladimirKuk any idea if those test failures are actually a symptom of the patch itself? Or is it just common for things to fail in the tests from time to time?

VladimirKuk · 2024-11-20T22:04:49Z

Tests do fail from time to time.
At least to me, these tests are unrelated to the change.

bradh352 · 2024-11-20T23:32:32Z

@prsunny please review

lukasstockner · 2024-11-27T19:25:00Z

Thank you for pushing this forward!
For the record, we've been running these changes in production for ~2 years without issues, so I'd be quite confident that they work as expected.

bradh352 · 2024-11-27T20:37:59Z

@prsunny ping

bradh352 · 2024-12-04T17:17:34Z

@VladimirKuk I ended up having to sprinkle your suggestion in 2 places to get it fully working.

orchagent/vxlanorch.cpp

bradh352 · 2024-12-07T11:04:19Z

@prsunny how would you like to proceed on this? I think this is a critical issue since community SONiC doesn't support ARP/ND suppression so things just don't work at all without this.

mssonicbld · 2024-12-13T14:11:35Z

/azp run

azure-pipelines · 2024-12-13T14:11:46Z

Azure Pipelines successfully started running 1 pipeline(s).

bradh352 · 2024-12-13T14:12:20Z

@prsunny looks like the internal msconflict is resolved now since pvst was merged to main. Please review and hopefully merge. Thanks!

mssonicbld · 2024-12-16T16:03:13Z

/azp run

@VladimirKuk

…onic-net#3383) This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)

@VladimirKuk

…onic-net#3383) This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)

@VladimirKuk

…onic-net#3383) This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)

@VladimirKuk

…onic-net#3383) This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)

@VladimirKuk

…onic-net#3383) This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)

@VladimirKuk

…onic-net#3383) This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)

bradh352 · 2025-01-22T14:38:02Z

@prsunny @dgsudharsan @srj102 any further feedback here? I'd really like to get this merged. There are lots of people using this patch already.

srj102 · 2025-01-22T15:50:50Z

@bradh352 Thanks for the fixes.

By keeping the create_tunnel helpers default values we are not impacting the other orchs like nvgre/srv6/tunneldecap.
The latest change you made is fine.

vnetorch also keeps the VXLAN tunnel created in the PIPE mode and hence we should be able to go with PIPE mode for BGP EVPN vxlan tunnels.

bradh352 · 2025-01-22T15:55:25Z

@bradh352 Thanks for the fixes.

By keeping the create_tunnel helpers default values we are not impacting the other orchs like nvgre/srv6/tunneldecap. The latest change you made is fine.

vnetorch also keeps the VXLAN tunnel created in the PIPE mode and hence we should be able to go with PIPE mode for BGP EVPN vxlan tunnels.

Can you mark it as approved?

Also, I recently acquired a Mellanox Spectrum1 switch (SN2201) for testing and can confirm this patch also works on that ASIC.

tests/test_vxlan_tunnel.py

mssonicbld · 2025-01-22T16:28:54Z

/azp run

azure-pipelines · 2025-01-22T16:29:06Z

Azure Pipelines successfully started running 1 pipeline(s).

@VladimirKuk

…onic-net#3383) This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)

@VladimirKuk

This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)

…nce TTL is set to non-zero

mssonicbld · 2025-01-23T13:21:20Z

/azp run

azure-pipelines · 2025-01-23T13:21:30Z

Azure Pipelines successfully started running 1 pipeline(s).

bradh352 · 2025-01-23T13:21:52Z

looks like builds were hanging yesterday ... I rebased my commits on current master to force a rebuild ... hopefully its fixed today.

mssonicbld · 2025-01-24T13:10:18Z

/azp run

azure-pipelines · 2025-01-24T13:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

bradh352 · 2025-01-24T13:10:35Z

just forced a rebuild, tests failed in srv6 tests ... shouldn't be related in any way to my changes

add to sip and dip tests for completeness

mssonicbld · 2025-01-25T12:45:51Z

/azp run

azure-pipelines · 2025-01-25T12:46:01Z

Azure Pipelines successfully started running 1 pipeline(s).

bradh352 · 2025-01-25T18:49:32Z

only failures in the log are srv6 related, just like the minimal PR in #3482 also failing due to SRV6 tests failing

bradh352 requested a review from prsunny as a code owner November 20, 2024 14:41

bradh352 force-pushed the vxlan-fixes branch 2 times, most recently from 603980f to 75c4f03 Compare November 20, 2024 14:49

This was referenced Nov 20, 2024

VxLAN fix tunnel oper_state issue #3216

Closed

Set tunnel id to saiOidToAlias for support update tunnel status. #2080

Open

VladimirKuk reviewed Nov 20, 2024

View reviewed changes

bradh352 mentioned this pull request Nov 20, 2024

NEIGH_TABLE not populated with VXLAN routes #3384

Open

bradh352 force-pushed the vxlan-fixes branch from 24f3487 to 3a80323 Compare December 4, 2024 16:58

bradh352 requested review from abdosi and judyjoseph as code owners December 4, 2024 16:58

bradh352 force-pushed the vxlan-fixes branch 3 times, most recently from 1ad6c1e to 89b365a Compare December 4, 2024 17:16

bradh352 mentioned this pull request Dec 5, 2024

[frr/bgpd] unified config missing fpm option breaking VXLAN EVPN sonic-net/sonic-buildimage#21034

Open

VladimirKuk approved these changes Dec 5, 2024

View reviewed changes

prsunny reviewed Dec 5, 2024

View reviewed changes

orchagent/vxlanorch.cpp Outdated Show resolved Hide resolved

prsunny force-pushed the master branch from d098ac8 to fa2b530 Compare December 11, 2024 18:22

bradh352 force-pushed the vxlan-fixes branch from a000ef4 to 6a9f067 Compare December 16, 2024 16:03

srj102 reviewed Jan 22, 2025

View reviewed changes

tests/test_vxlan_tunnel.py Show resolved Hide resolved

srj102 approved these changes Jan 22, 2025

View reviewed changes

bradh352 added 3 commits January 23, 2025 08:21

vxlan: update test case to check for required attributes

74238d1

revisions as per @srj102. revert changes to create_tunnel() helper si…

4149ce5

…nce TTL is set to non-zero

bradh352 force-pushed the vxlan-fixes branch from 6c8ea59 to 4f6ba41 Compare January 23, 2025 13:21

bradh352 force-pushed the vxlan-fixes branch from 4f6ba41 to 05c3f51 Compare January 24, 2025 13:10

add additional test verifications as per @srj102

f461115

add to sip and dip tests for completeness

bradh352 force-pushed the vxlan-fixes branch from 05c3f51 to f461115 Compare January 25, 2025 12:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[orchagent]: VXLAN: Fix oper_status and tunnel encapsulation TTL #3383

[orchagent]: VXLAN: Fix oper_status and tunnel encapsulation TTL #3383

bradh352 commented Nov 20, 2024 •

edited

Loading

linux-foundation-easycla bot commented Nov 20, 2024 •

edited

Loading

VladimirKuk left a comment

bradh352 commented Nov 20, 2024

VladimirKuk commented Nov 20, 2024

bradh352 commented Nov 20, 2024

lukasstockner commented Nov 27, 2024

bradh352 commented Nov 27, 2024

bradh352 commented Dec 4, 2024

bradh352 commented Dec 7, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

bradh352 commented Dec 13, 2024

mssonicbld commented Dec 16, 2024

bradh352 commented Jan 22, 2025

srj102 commented Jan 22, 2025

bradh352 commented Jan 22, 2025

mssonicbld commented Jan 22, 2025

azure-pipelines bot commented Jan 22, 2025

mssonicbld commented Jan 23, 2025

azure-pipelines bot commented Jan 23, 2025

bradh352 commented Jan 23, 2025

mssonicbld commented Jan 24, 2025

azure-pipelines bot commented Jan 24, 2025

bradh352 commented Jan 24, 2025

mssonicbld commented Jan 25, 2025

azure-pipelines bot commented Jan 25, 2025

bradh352 commented Jan 25, 2025

[orchagent]: VXLAN: Fix oper_status and tunnel encapsulation TTL #3383

Are you sure you want to change the base?

[orchagent]: VXLAN: Fix oper_status and tunnel encapsulation TTL #3383

Conversation

bradh352 commented Nov 20, 2024 • edited Loading

linux-foundation-easycla bot commented Nov 20, 2024 • edited Loading

VladimirKuk left a comment

Choose a reason for hiding this comment

bradh352 commented Nov 20, 2024

VladimirKuk commented Nov 20, 2024

bradh352 commented Nov 20, 2024

lukasstockner commented Nov 27, 2024

bradh352 commented Nov 27, 2024

bradh352 commented Dec 4, 2024

bradh352 commented Dec 7, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

bradh352 commented Dec 13, 2024

mssonicbld commented Dec 16, 2024

bradh352 commented Jan 22, 2025

srj102 commented Jan 22, 2025

bradh352 commented Jan 22, 2025

mssonicbld commented Jan 22, 2025

azure-pipelines bot commented Jan 22, 2025

mssonicbld commented Jan 23, 2025

azure-pipelines bot commented Jan 23, 2025

bradh352 commented Jan 23, 2025

mssonicbld commented Jan 24, 2025

azure-pipelines bot commented Jan 24, 2025

bradh352 commented Jan 24, 2025

mssonicbld commented Jan 25, 2025

azure-pipelines bot commented Jan 25, 2025

bradh352 commented Jan 25, 2025

bradh352 commented Nov 20, 2024 •

edited

Loading

linux-foundation-easycla bot commented Nov 20, 2024 •

edited

Loading