[portorch] Add capability to add unreliable LOS setting to a PORT via config #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This pull request introduces a new capability in the SONiC system: support for handling ports with "unreliable loss of signal" (unreliable LOS). The aim is to improve how the system manages situations where ports intermittently fail to detect signals reliably.
Why I did it
The implementation includes new helper methods. Functions like getUnreliableLosStr and parsePortUnreliableLos have been introduced to handle the conversion and parsing of the unreliable LOS field during configuration processing. The existing parsePortConfig method has been updated to integrate these changes seamlessly, ensuring the system correctly interprets and applies the new settings.
A new schema entry, PORT_UNRELIABLE_LOS, has been defined to standardize how this configuration is represented and handled across the system
How I verified it
Details if related