[chassis][cli] Fix config chassis module startup/shutdown command for…

… fabric module (#3483)

* [chassis][cli] Fix config chassis module starup/shutdown command for fabric module

Signed-off-by: mlok <marty.lok@nokia.com>

* Address review comment: modify UT to test if the run_command parameter type is list

Signed-off-by: mlok <marty.lok@nokia.com>

---------

Signed-off-by: mlok <marty.lok@nokia.com>

config/chassis_modules.py

@@ -72,7 +72,7 @@ def fabric_module_set_admin_status(db, chassis_module_name, state):
  if state == "down":
  for asic in asic_list:
  click.echo("Stop swss@{} and peer services".format(asic))
- clicommon.run_command('sudo systemctl stop swss@{}.service'.format(asic))
+ clicommon.run_command(['sudo', 'systemctl', 'stop', 'swss@{}.service'.format(asic)])
 
  is_active = subprocess.call(["systemctl", "is-active", "--quiet", "swss@{}.service".format(asic)])
 
@@ -89,13 +89,13 @@ def fabric_module_set_admin_status(db, chassis_module_name, state):
  # without bring down the hardware
  for asic in asic_list:
  # To address systemd service restart limit by resetting the count
- clicommon.run_command('sudo systemctl reset-failed swss@{}.service'.format(asic))
+ clicommon.run_command(['sudo', 'systemctl', 'reset-failed', 'swss@{}.service'.format(asic)])
  click.echo("Start swss@{} and peer services".format(asic))
- clicommon.run_command('sudo systemctl start swss@{}.service'.format(asic))
+ clicommon.run_command(['sudo', 'systemctl', 'start', 'swss@{}.service'.format(asic)])
  elif state == "up":
  for asic in asic_list:
  click.echo("Start swss@{} and peer services".format(asic))
- clicommon.run_command('sudo systemctl start swss@{}.service'.format(asic))
+ clicommon.run_command(['sudo', 'systemctl', 'start', 'swss@{}.service'.format(asic)])
 
 #
 # 'shutdown' subcommand ('config chassis_modules shutdown ...')

tests/chassis_modules_test.py

@@ -126,7 +126,13 @@
 
 
 def mock_run_command_side_effect(*args, **kwargs):
- return '', 0
+ print("command: {}".format(*args))
+ if isinstance(*args, list):
+ return '', 0
+ else:
+ print("Expected type of command is list. Actual type is {}".format(*args))
+ assert 0
+ return '', 0
 
 
 class TestChassisModules(object):