Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Check golden config exist early if flag is set #3169

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Feb 18, 2024

ADO: 27299196

What I did

Fix #3164
Check Golden Config earlier before service is down.

How I did it

Move the check at the begining

How to verify it

Unit test

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@xumia
Copy link
Collaborator

xumia commented Feb 21, 2024

/azp run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xumia
Copy link
Collaborator

xumia commented Feb 21, 2024

/azp run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xumia
Copy link
Collaborator

xumia commented Feb 22, 2024

/azp run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xumia
Copy link
Collaborator

xumia commented Feb 22, 2024

/azp run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit 6e4130d into sonic-net:master Feb 22, 2024
5 checks passed
wen587 added a commit to wen587/sonic-utilities that referenced this pull request Aug 27, 2024
### What I did
Fix  sonic-net#3164
Check Golden Config earlier before service is down.
#### How I did it
Move the check at the begining
#### How to verify it
Unit test
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Aug 28, 2024
### What I did
Fix  sonic-net#3164
Check Golden Config earlier before service is down.
#### How I did it
Move the check at the begining
#### How to verify it
Unit test
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #3504

yxieca pushed a commit that referenced this pull request Aug 28, 2024
### What I did
Fix  #3164
Check Golden Config earlier before service is down.
#### How I did it
Move the check at the begining
#### How to verify it
Unit test

Co-authored-by: jingwenxie <jingwenxie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

override_config should fail immediately if the file does not exist
6 participants