Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show fabric rate command #3297

Merged
merged 4 commits into from
May 20, 2024

Conversation

jfeng-arista
Copy link
Contributor

@jfeng-arista jfeng-arista commented Apr 30, 2024

What I did

Added "show fabric counters rate mbps" command.

The output of the command is

  ASIC    Link ID    Rx Data Mbps    Tx Data Mbps
------  ---------  --------------  --------------
 asic0          0               0            19.8
 asic0          1               0            19.8
 asic0          2               0            39.8
 asic0          3               0            39.8
...

  ASIC    Link ID    Rx Data Mbps    Tx Data Mbps
------  ---------  --------------  --------------
 asic1          0               0               0
 asic1          1               0               0
 asic1          2               0               0
 asic1          3               0               0
...

The HLD is at here

https://github.com/sonic-net/SONiC/blob/master/doc/voq/fabric.md
Amendment is at sonic-net/SONiC#1656

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@kenneth-arista
Copy link
Contributor

@arlakshm

@arlakshm arlakshm added the chassis-voq Changes for VoQ chassis label Apr 30, 2024
show/fabric.py Outdated

@rate.command()
@multi_asic_util.multi_asic_click_option_namespace
def mbps(namespace):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this? can we have the command show fabric counters rate and we can have the default speed as mbps ?

Copy link
Contributor Author

@jfeng-arista jfeng-arista Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this? can we have the command show fabric counters rate and we can have the default speed as mbps ?

Thank you for your comments . I was just following the one that we discussed in the HLD ( 2.8.3) , let me know if this is ok or want me change to the new command format that you mentioned and update the HLD as well.

thank you

Copy link
Contributor Author

@jfeng-arista jfeng-arista May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this? can we have the command show fabric counters rate and we can have the default speed as mbps ?

Thank you for your comments . I was just following the one that we discussed in the HLD ( 2.8.3) , let me know if this is ok or want me change to the new command format that you mentioned and update the HLD as well.

thank you

revised after last Friday's discussion, and update the HLD as well (at sonic-net/SONiC#1656 )

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm arlakshm merged commit 7298cd2 into sonic-net:master May 20, 2024
7 checks passed
ryanzhu706 added a commit to ryanzhu706/sonic-utilities that referenced this pull request May 31, 2024
What I did
Added "show fabric counters rate mbps" command.

The output of the command is

  ASIC    Link ID    Rx Data Mbps    Tx Data Mbps
------  ---------  --------------  --------------
 asic0          0               0            19.8
 asic0          1               0            19.8
 asic0          2               0            39.8
 asic0          3               0            39.8
...

  ASIC    Link ID    Rx Data Mbps    Tx Data Mbps
------  ---------  --------------  --------------
 asic1          0               0               0
 asic1          1               0               0
 asic1          2               0               0
 asic1          3               0               0
...

The HLD is at here

https://github.com/sonic-net/SONiC/blob/master/doc/voq/fabric.md
Amendment is at sonic-net/SONiC#1656
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
What I did
Added "show fabric counters rate mbps" command.

The output of the command is

  ASIC    Link ID    Rx Data Mbps    Tx Data Mbps
------  ---------  --------------  --------------
 asic0          0               0            19.8
 asic0          1               0            19.8
 asic0          2               0            39.8
 asic0          3               0            39.8
...

  ASIC    Link ID    Rx Data Mbps    Tx Data Mbps
------  ---------  --------------  --------------
 asic1          0               0               0
 asic1          1               0               0
 asic1          2               0               0
 asic1          3               0               0
...

The HLD is at here

https://github.com/sonic-net/SONiC/blob/master/doc/voq/fabric.md
Amendment is at sonic-net/SONiC#1656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chassis-voq Changes for VoQ chassis
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants