-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show fabric rate command #3297
Add show fabric rate command #3297
Conversation
show/fabric.py
Outdated
|
||
@rate.command() | ||
@multi_asic_util.multi_asic_click_option_namespace | ||
def mbps(namespace): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this? can we have the command show fabric counters rate
and we can have the default speed as mbps
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this? can we have the command
show fabric counters rate
and we can have the default speed asmbps
?
Thank you for your comments . I was just following the one that we discussed in the HLD ( 2.8.3) , let me know if this is ok or want me change to the new command format that you mentioned and update the HLD as well.
thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this? can we have the command
show fabric counters rate
and we can have the default speed asmbps
?Thank you for your comments . I was just following the one that we discussed in the HLD ( 2.8.3) , let me know if this is ok or want me change to the new command format that you mentioned and update the HLD as well.
thank you
revised after last Friday's discussion, and update the HLD as well (at sonic-net/SONiC#1656 )
/Azp run Azure.sonic-utilities |
Azure Pipelines successfully started running 1 pipeline(s). |
What I did Added "show fabric counters rate mbps" command. The output of the command is ASIC Link ID Rx Data Mbps Tx Data Mbps ------ --------- -------------- -------------- asic0 0 0 19.8 asic0 1 0 19.8 asic0 2 0 39.8 asic0 3 0 39.8 ... ASIC Link ID Rx Data Mbps Tx Data Mbps ------ --------- -------------- -------------- asic1 0 0 0 asic1 1 0 0 asic1 2 0 0 asic1 3 0 0 ... The HLD is at here https://github.com/sonic-net/SONiC/blob/master/doc/voq/fabric.md Amendment is at sonic-net/SONiC#1656
What I did Added "show fabric counters rate mbps" command. The output of the command is ASIC Link ID Rx Data Mbps Tx Data Mbps ------ --------- -------------- -------------- asic0 0 0 19.8 asic0 1 0 19.8 asic0 2 0 39.8 asic0 3 0 39.8 ... ASIC Link ID Rx Data Mbps Tx Data Mbps ------ --------- -------------- -------------- asic1 0 0 0 asic1 1 0 0 asic1 2 0 0 asic1 3 0 0 ... The HLD is at here https://github.com/sonic-net/SONiC/blob/master/doc/voq/fabric.md Amendment is at sonic-net/SONiC#1656
What I did
Added "show fabric counters rate mbps" command.
The output of the command is
The HLD is at here
https://github.com/sonic-net/SONiC/blob/master/doc/voq/fabric.md
Amendment is at sonic-net/SONiC#1656
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)