[config] no op if Golden Config is invalid #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
previously approved these changes
Jun 17, 2024
ganglyu
approved these changes
Jun 18, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Aug 23, 2024
ADO: 27941719 What I did Improve Golden Config workflow and make sure no op if invalid config detected How I did it Add table dependency check right after Golden Config path is enabled How to verify it Unit test
|
Cherry-pick PR to 202405: #3498 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 24, 2024
ADO: 27941719 What I did Improve Golden Config workflow and make sure no op if invalid config detected How I did it Add table dependency check right after Golden Config path is enabled How to verify it Unit test
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
wen587
added a commit
to wen587/sonic-utilities
that referenced
this pull request
Aug 27, 2024
ADO: 27941719 What I did Improve Golden Config workflow and make sure no op if invalid config detected How I did it Add table dependency check right after Golden Config path is enabled How to verify it Unit test
wen587
added
Request for 202311 Branch
and removed
Request for 202311 Branch
Cherry Pick Conflict_202311
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Aug 28, 2024
ADO: 27941719 What I did Improve Golden Config workflow and make sure no op if invalid config detected How I did it Add table dependency check right after Golden Config path is enabled How to verify it Unit test
|
Cherry-pick PR to 202311: #3506 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2024
ADO: 27941719 What I did Improve Golden Config workflow and make sure no op if invalid config detected How I did it Add table dependency check right after Golden Config path is enabled How to verify it Unit test
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO: 27941719
What I did
Improve Golden Config workflow and make sure no op if invalid config detected
How I did it
Add table dependency check right after Golden Config path is enabled
How to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)