[mmuconfig] Purge redundant mmuconfig file #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alpeshspatel Can you confirm if this file is not being used and is safe to purge? |
|
the top level file (with pdb import) seems got added by mistake. yes ok to remove - Thanks! |
arista-hpandya
changed the title
|
A gentle nudge for a reviewer to review/merge it. |
|
@arlakshm @wenyiz2021 can you help merge this cleanup fix? |
wenyiz2021
approved these changes
Sep 4, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
close and reopen to trigger Semgrep |
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Sep 6, 2024
|
Cherry-pick PR to 202405: #3531 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 6, 2024
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I removed the mmuconfig script under sonic-utilities which was orginally added in #2775 . This is because I noticed that this was potentially redundant as all scripts including mmuconfig are stored under the scripts/ folder. Additionally I believe this was a debug file which was not meant to be merged as I notice that there are pdb traces in this file.
How I did it
Purge the file
How to verify it
I verified that it was redundant by running the unit tests for sonic-utilities and comparing the file contents to the scripts/mmuconfig file.
Previous command output (if the output of a command-line utility has changed)
NA
New command output (if the output of a command-line utility has changed)
NA