Exit early if YANG validation fails in Golden Config #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wen587
force-pushed
the
golden_exit_early
branch
from
a278b06
to
16481df
Compare
wen587
requested review from
qiluo-msft,
isabelmsft,
ganglyu and
xincunli-sonic
ganglyu
previously approved these changes
Aug 19, 2024
Currently it only has dependency check about AAA which is only exist in host. It is weakened version of YANG validation based on PROD issue. I think after yang validation enabled, we can remove it or just add parts that YANG could not covered. |
qiluo-msft
reviewed
Aug 20, 2024
qiluo-msft
reviewed
Aug 20, 2024
wen587
force-pushed
the
golden_exit_early
branch
from
16481df
to
b963673
Compare
ganglyu
approved these changes
Sep 3, 2024
FengPan-Frank
approved these changes
Sep 3, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Sep 5, 2024
What I did Exit early if golden config fails YANG validation How I did it Check before stop service in load_minigraph How to verify it Unit test Previous command output (if the output of
|
Cherry-pick PR to 202405: #3522 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 5, 2024
What I did Exit early if golden config fails YANG validation How I did it Check before stop service in load_minigraph How to verify it Unit test Previous command output (if the output of
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Sep 6, 2024
What I did Exit early if golden config fails YANG validation How I did it Check before stop service in load_minigraph How to verify it Unit test Previous command output (if the output of
|
Cherry-pick PR to 202311: #3527 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 6, 2024
What I did Exit early if golden config fails YANG validation How I did it Check before stop service in load_minigraph How to verify it Unit test Previous command output (if the output of
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO: 29254166
What I did
Exit early if golden config fails YANG validation
How I did it
Check before stop service in load_minigraph
How to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)