Support for fabric link monitoring feature on SUP #3493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saksarav-nokia @kenneth-arista for review. |
|
@vmittal-msft it looks like your PR is based on Tagging @jfeng-arista for awareness |
arlakshm
reviewed
Aug 24, 2024
| self.filter_for_up_ports = filter_for_up_ports | ||
| self.port_map = self.get_port_map() | ||
| print('Fabric device id :', namespace) | ||
| subprocess.run(["sonic-clear", "fabriccountersport"]) |
There was a problem hiding this comment.
why clear the counter via CLI, it does not clear the DB entries
No. Moving to sonic-utilities.msft. |
|
Closing this PR on master and opening for 202205/msft repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support for Fabric link monitoring on SUP to log critical syslog if a link is seeing high crc error. This is for 202205 only as master will have complete support of fabric link monitoring
How I did it
A python script will be launched by monit to periodically monitor link state and if a link sees high rate of crc error then a syslog will be generated to record this. We can plan to add link shutdown support later.
How to verify it
Verified this on lab as well as production pilot devices.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)