Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:3424] [Bug Fix] Fix disk check test and drops group test (#3424) #3499

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

mssonicbld
Copy link
Collaborator

  • tests/disk_check_test.py: remove temp files during teardown
  • modify teardown_class() to remove /tmp/tmp*
  • tests/drops_group_test.py: add code to remove temporary files when setting up test class
  • add a remove_tmp_dropstat_file() function as a helper to clean the cache
  • add an invocation of remove_tmp_dropstat_file() in setup_class() of TestDropCounters class
  • tests/disk_check_test.py: fix the subprocess command in the teardown_class() function

  • tests/disk_check_test.py: fix formatting for pre-commit check

  • tests/drops_group_test.py: fix formatting for pre-commit check

* tests/disk_check_test.py: remove temp files during teardown

- modify teardown_class() to remove /tmp/tmp*

* tests/drops_group_test.py: add code to remove temporary files when setting up test class

- add a remove_tmp_dropstat_file() function as a helper to clean the cache
- add an invocation of remove_tmp_dropstat_file() in setup_class() of TestDropCounters class

* tests/disk_check_test.py: fix the subprocess command in the teardown_class() function

* tests/disk_check_test.py: fix formatting for pre-commit check

* tests/drops_group_test.py: fix formatting for pre-commit check
@mssonicbld
Copy link
Collaborator Author

Original PR: #3424

@mssonicbld mssonicbld merged commit 1f4315e into sonic-net:202405 Aug 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants