-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-asic support to PFC config/show #3521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add namespace arg for show and config cmds for pfc - Replace test DB with JSON to support verification of multiple namespaces in unit test - Add unit tests for multi-asic behaviour - Added a test vector file for better test organization
arista-hpandya
changed the title
Add multi-asic support to PFC config/show
Fix multi-asic support to PFC config/show
Sep 4, 2024
wenyiz2021
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result pasted in PR description LGTM
to be cherry pick in 202405, after #3057 is ported to 202405 |
wenyiz2021
added a commit
that referenced
this pull request
Sep 5, 2024
This reverts commit 785d7bd.
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Sep 20, 2024
* Add multi-asic support to pfc - Add namespace arg for show and config cmds for pfc - Replace test DB with JSON to support verification of multiple namespaces in unit test - Add unit tests for multi-asic behaviour - Added a test vector file for better test organization * Fix linter errors
Cherry-pick PR to 202405: #3550 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Add multi-asic support to pfc - Add namespace arg for show and config cmds for pfc - Replace test DB with JSON to support verification of multiple namespaces in unit test - Add unit tests for multi-asic behaviour - Added a test vector file for better test organization * Fix linter errors
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added multi-asic support to PFC show and config commands by:
This is a logical successor of #3057 and is a part of the larger efforts to add multi-asic functionality tracked in #15148
How I did it
I used the multi_asic helper functions from
sonic_py_common
andutilities_common
to handle multiple namespacesHow to verify it
There were three stages of verification:
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
The namespace argument is the new addition to the pfc command.
Case 1: If namespace is specified in a multi-asic device
Behaviour: We will run the command only on the specified namespace
e.g:
pfc show asymmetric --namespace asic0
Case 2: If no namespace is specified in a multi-asic device
Behaviour: We will run the command on all namespaces
e.g:
pfc show priority
Case 3: If a namespace is specified in single-asic device (other than default '')
Behaviour: We will raise an invalid argument error
e.g:
pfc show asymmetric --namespace asic0
Case 4: If no namespace is specified in single-asic device
Behaviour: We will run it on the only valid namespace - default namespace
e.g:
pfc show priority