[spm]: Clean up timers auto generation logic #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
nazariig
requested review from
dgsudharsan,
stepanblyschak,
liat-grozovik and
volodymyrsamotiy
noaOrMlnx
approved these changes
Sep 5, 2024
DavidZagury
approved these changes
Sep 5, 2024
qiluo-msft
approved these changes
Sep 15, 2024
bingwang-ms
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Oct 21, 2024
Config Reload Enhancements PR sonic-net/SONiC#1203 does not completely remove TIMERs from SONiC Package Manager infra. This PR is intended to complete the original changes. `Systemd` TIMERs infra was replaced by `hostcfgd` service management. That was done to improve reliability of service management. #### What I did * Removed redundant TIMERs infra #### How I did it * Updated SPM auto generation logic #### How to verify it 1. Install application extension ```bash spm install --from-tarball <app_ext_path> ``` 2. Make sure `delayed` flag is set ```bash docker image inspect <app_ext_image> | jq '.[].Config.Labels["com.azure.sonic.manifest"]' | python -c 'import sys,ast; print(ast.literal_eval(sys.stdin.read()))' | jq .service.delayed true ``` 3. Check no TIMERs were generated
|
Cherry-pick PR to 202405: #3582 |
mssonicbld
pushed a commit
that referenced
this pull request
Oct 22, 2024
Config Reload Enhancements PR sonic-net/SONiC#1203 does not completely remove TIMERs from SONiC Package Manager infra. This PR is intended to complete the original changes. `Systemd` TIMERs infra was replaced by `hostcfgd` service management. That was done to improve reliability of service management. #### What I did * Removed redundant TIMERs infra #### How I did it * Updated SPM auto generation logic #### How to verify it 1. Install application extension ```bash spm install --from-tarball <app_ext_path> ``` 2. Make sure `delayed` flag is set ```bash docker image inspect <app_ext_image> | jq '.[].Config.Labels["com.azure.sonic.manifest"]' | python -c 'import sys,ast; print(ast.literal_eval(sys.stdin.read()))' | jq .service.delayed true ``` 3. Check no TIMERs were generated
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
Config Reload Enhancements PR sonic-net/SONiC#1203 does not completely remove TIMERs from SONiC Package Manager infra. This PR is intended to complete the original changes.
SystemdTIMERs infra was replaced byhostcfgdservice management.That was done to improve reliability of service management.
What I did
How I did it
How to verify it
delayedflag is setPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
A picture of a cute animal (not mandatory but encouraged)