-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SmartSwitch] Extend reboot script for rebooting SmartSwitch #3566
base: master
Are you sure you want to change the base?
Conversation
460146c
to
c72fbc0
Compare
8746356
to
d6fc624
Compare
scripts/reboot
Outdated
debug "User requested rebooting device ${DPU_NAME} ..." | ||
|
||
# Retrieve DPU IP and GNMI port | ||
dpu_ip=$(get_dpu_ip "${DPU_NAME}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both get_dpu_ip
and get_gnmi_port
do not return anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be because the code might not be present for this in sonic image. I will check on the possible ETA for the changes in that case. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpunathilell gnmi port changes are expected to be available by 11/15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I meant was the function call is not returning anything as we have no echo statements from the function(even if the gnmi ports are added manually the function doesn't return anything, and the value in dpu_ip
is being overwritten with empty string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the config DB set properly on the server? could you please check "sonic-db-cli CONFIG_DB HGET "DHCP_SERVER_IPV4_PORT|bridge-midplane|DPU<#>" "ips@""" is returning valid value?
What I did
Extended reboot script for SmartSwitch cases to reboot entire SmartSwitch or a specific DPU
How I did it
Implemented changes according to https://github.com/sonic-net/SONiC/blob/605c3a56ac2717dbbb638433e7bb13054fc05a31/doc/smart-switch/reboot/reboot-hld.md
How to verify it
--Pending testing on SmartSwitch--
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)