Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db_migrator][telemetry] Remove the telemetry from the feature table #3568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlok-nokia
Copy link
Contributor

What I did

Feature telemetry has been replaced by GNMI. This PR removes the telemetry feature from FEATURE table to avoid the logging message shown up every minute when upgrade a platform from 202205 to 202405 image. It fixes sonic-net/sonic-buildimage#20056.

The following is the log message:

2024 Aug 28 15:35:12.219750 Linecard WARNING Chassis: Failed to get image 'docker-sonic-telemetry'. Error: '404 Client Error for http+docker://localhost/v1.43/images/docker-sonic-telemetry/json: Not Found ("No such image: docker-sonic-telemetry:latest")'

How I did it

Modified the db_migrator by adding function migrate_remove_feature() to remove the telemetry related configuration in the CONFIG_DB if telemetry config exists. Configuration includes "FEATURE|telemetry" and "AUTO_TECHSUPPORT|telemetry"

How to verify it

  1. Upgrade a platform which is running 202205 image.
  2. Using the following command to verify the telemetry is no longer in the CONFIG_BD
admin@ixre-egl-board25:~$ sonic-db-dump -n CONFIG_DB -y -k "FEATURE|telemetry"
{}
admin@ixre-egl-board25:~$ sonic-db-dump -n CONFIG_DB -y -k "AUTO_TECHSUPPORT_FEATURE|telemetry"
{}
  1. Check the syslog. The following message should not be shown
Linecard WARNING Chassis: Failed to get image 'docker-sonic-telemetry'. Error: '404 Client Error for http+docker://localhost/v1.43/images/docker-sonic-telemetry/json: Not Found ("No such image: docker-sonic-telemetry:latest")'

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@rlhui rlhui requested a review from qiluo-msft November 8, 2024 02:04
@rlhui
Copy link
Contributor

rlhui commented Nov 8, 2024

@qiluo-msft would you please help review? thanks.

@mlok-nokia
Copy link
Contributor Author

@qiluo-msft Should we remove the telemetry feature from feature table on 202405 branch and after? If this is the approach, I will fix the UNIT to do that too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
2 participants