Revise RJ45 Port Type Check #3606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: For the RJ45 port, the port_transceiver_info is None. This is because that the XCVRD will not update TRANSCEIVER_INFO into STATE DB for the RJ45 port. Solution: If port_transceiver_info is None, apply the same method used in intfutil.
PJHsieh
force-pushed
the
Revise_RJ45_Port_Type_Check
branch
from
b45e0cb
to
a389a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
For the RJ45 port, the port_transceiver_info is None. This is because that the XCVRD will not update TRANSCEIVER_INFO into STATE DB for the RJ45 port.
How I did it
If port_transceiver_info is None,
apply the same method used in intfutil.
How to verify it
Set link-training on RJ45 port, the error msg "Setting RJ45 ports' link-training is not supported" must be displayed.
Set interface type on RJ45 port, the error msg "Setting RJ45 ports' type is not supported" must be displayed.
Set advertised-types on RJ45 port, the error msg "Setting RJ45 ports' advertised types is not supported" must be displayed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)