Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Depressurizer Support #1029

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove Depressurizer Support #1029

wants to merge 1 commit into from

Conversation

sonic2kk
Copy link
Owner

This PR removes support for Depressurizer. I do not use this tool or know anything about it, I'm also not sure if anyone uses it with STL. I heard a couple of times in passing in unrelated issues that it doesn't work anymore.

This PR is pretty sweeping and will need testing before it is merged. If someone is using it and/or if someone is vocal about keeping it, then this PR can be closed.

I am not planning to merge this PR until after v14.0. There have been significant changes since the last release, and someone may want to restore Depressurizer support on top of v14.0. Not merging until after release will give a more functional base release to work with restoring and fixing. Of course if anyone does this they're free to merge it back upstream if they are interested in keeping Depressurizer in STL (some people may not be vocal about a change until it is already made).

Opening as a draft as unsure yet if it should be removed. It has also not been tested outside of running a quick ShellCheck.

@sonic2kk
Copy link
Owner Author

sonic2kk commented Mar 6, 2024

The current plan is to go forward with this after v14.0. Should probably rebase this regularly to make sure it's ready for merging come the time, just in case.

If someone wants to fork and re-add Depressurizer for their own purposes, they should be able to use the diff of this PR to do so. This also needs some more testing to make sure nothing unrelated is broken, so this will stay in draft for a while longer.

@sonic2kk sonic2kk mentioned this pull request Mar 12, 2024
@sonic2kk sonic2kk added shellcheck Run ShellCheck workflow against PR and removed shellcheck Run ShellCheck workflow against PR labels Mar 20, 2024
@sonic2kk sonic2kk added the shellcheck Run ShellCheck workflow against PR label Mar 20, 2024
@sonic2kk sonic2kk added shellcheck Run ShellCheck workflow against PR and removed shellcheck Run ShellCheck workflow against PR labels Mar 20, 2024
@sonic2kk sonic2kk force-pushed the remove-depressurizer branch 2 times, most recently from c9ec1e1 to ce385c8 Compare March 25, 2024 00:42
@sonic2kk sonic2kk force-pushed the remove-depressurizer branch 2 times, most recently from f46de23 to dab7f5b Compare June 16, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant