Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luxtorpeda: Update default LUXTORPEDACMD path #1179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Sep 30, 2024

Came up in #1177.
Related: #1178.

Luxtorpeda now uses a different launch command; luxtorpeda.sh instead of luxtorpeda. This PR updates the default path so that it uses this newer one.

This won't retroactively affect global configs, it will only affect newly-created global configs. Not all users may be using a newer Luxtorpeda version that uses this newer entry point, but I think it makes sense for our default value to be what upstream uses as the default. If the path doesn't exist, then it won't show up in the Global Menu Yad box for it, and the user can surmise that the executable was not found and set the path themselves from here or in global.conf manually (similar to what I described for the invalid path in #1178).

TODO:

  • Check if the same applies for Roberta.
  • Update Luxtorpeda wiki to note the new default path.
  • Version bump

@sonic2kk sonic2kk changed the title Luxtorpeda: Update default LUXTORPEDACMD path Luxtorpeda: Update default LUXTORPEDACMD path Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant