Rework handling of if expressions
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes sorawee#75. Repeat attempt of sorawee#77, this time without the splash damage on normal function application.
sorawee
approved these changes
Oct 11, 2024
| (let loop ([pos 0] | ||
| [l (append field-names private-field-names)]) | ||
| (if (null? l) null (cons pos (loop (add1 pos) (cdr l)))))] | ||
| [(local-field-pos ...) (let loop ([pos 0] |
There was a problem hiding this comment.
@jackfirth this is what I told you earlier... Probably there should be a newline here. But let's not worry about it in this PR.
| @@ -2188,7 +2202,10 @@ last few projections. | |||
| (null? augride-names) | |||
| (null? final-names))] | |||
| [no-new-fields? (null? public-field-names)] | |||
| [xappend (lambda (a b) (if (null? b) a (append a b)))]) | |||
| [xappend (lambda (a b) | |||
There was a problem hiding this comment.
This one, too. Though I feel it could go either way in this specific case (perhaps because the LHS is just a single identifier?)
There was a problem hiding this comment.
This one I would write on the next line too. In general, I strongly prefer adding linebreaks at the highest level of nesting first, even if that means more vertical space is used overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75. Repeat attempt of #77, this time without the splash damage on normal function application.