-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FastAPI Implementation of Sotopia Part One (wo websocket) #246
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 72.88% 74.47% +1.59%
==========================================
Files 58 61 +3
Lines 2972 3162 +190
==========================================
+ Hits 2166 2355 +189
- Misses 806 807 +1
|
Could you add tests to the implementation? FastAPI has a test runner which could be very useful: https://fastapi.tiangolo.com/tutorial/testing/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a naming suggestion: in pyproject.toml, we can rename the extra dependency group chat
to api
. The original name is for the chat frontend, while we are now exposing api
for simulation
Closes #
π Description
This pull request shows an initial implementation of the fastapi server wo the websocket part
β Checks
type/descript
(e.g.feature/add-llm-agents
)βΉ Additional Information