Fix SAML name extractor for students (#1148)

* Use name assertions for students

* Update test

lib/cadet/auth/providers/saml/nusstu_assertion_extractor.ex

@@ -10,6 +10,8 @@ defmodule Cadet.Auth.Providers.NusstuAssertionExtractor do
  end
 
  def get_name(assertion) do
- Map.get(assertion.attributes, "samaccountname")
+ first_name = Map.get(assertion.attributes, "givenname")
+ last_name = Map.get(assertion.attributes, "surname")
+ "#{first_name} #{last_name}"
  end
 end

test/cadet/auth/providers/saml/nusstu_assertion_extractor_test.exs

@@ -4,10 +4,18 @@ defmodule Cadet.Auth.Providers.NusstuAssertionExtractorTest do
  alias Cadet.Auth.Providers.NusstuAssertionExtractor, as: Testee
 
  @username "JohnT"
- @assertion %{attributes: %{"samaccountname" => @username}}
+ @firstname "John"
+ @lastname "Tan"
+ @assertion %{
+ attributes: %{
+ "samaccountname" => @username,
+ "givenname" => @firstname,
+ "surname" => @lastname
+ }
+ }
 
  test "success" do
  assert @username == Testee.get_username(@assertion)
- assert @username == Testee.get_name(@assertion)
+ assert @firstname <> " " <> @lastname == Testee.get_name(@assertion)
  end
 end