Remove bonus xp #1089
Merged
Remove bonus xp #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we fix the tests? |
|
I fixed the test cases but I found a bug where the bonus xp is given through current time not submission time. This creates a bug where bonus xp is given when the grader grades rather than when the user submits. I'll be working on fixing this before it can be merged. |
…to pr/thortol/1089
|
Can I check that this does not require any frontend change? |
|
Yes, this does not require any frontend change. |
RichDom2185
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2226.
There are occasional "low effort" submissions from students to gain the early submission bonus XP. This PR fixes this while not changing the workload for the avengers.
Previously, bonus XP will be awarded once students finalize submission. Now, when a student finalizes submission, there will be a check whether the autograder scored the submission as 0 or not. If a 0 was given, bonus XP will be 0. Else it will be the full amount. After the tutor marks finish the submission, another check will be done. If the submission is still a 0. bonus XP will be 0. Else, the full amount will be given.
Type of change
How to test
Checklist