-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bonus xp #1089
Remove bonus xp #1089
Conversation
Can we fix the tests? |
I fixed the test cases but I found a bug where the bonus xp is given through current time not submission time. This creates a bug where bonus xp is given when the grader grades rather than when the user submits. I'll be working on fixing this before it can be merged. |
…to pr/thortol/1089
Can I check that this does not require any frontend change? |
Yes, this does not require any frontend change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot! Sorry for the late review…
Description
Resolves #2226.
There are occasional "low effort" submissions from students to gain the early submission bonus XP. This PR fixes this while not changing the workload for the avengers.
Previously, bonus XP will be awarded once students finalize submission. Now, when a student finalizes submission, there will be a check whether the autograder scored the submission as 0 or not. If a 0 was given, bonus XP will be 0. Else it will be the full amount. After the tutor marks finish the submission, another check will be done. If the submission is still a 0. bonus XP will be 0. Else, the full amount will be given.
Type of change
How to test
Checklist