Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared links frontend refactor #2937

Merged
merged 11 commits into from
Apr 15, 2024
Merged

Shared links frontend refactor #2937

merged 11 commits into from
Apr 15, 2024

Conversation

chownces
Copy link
Contributor

@chownces chownces commented Apr 14, 2024 •
edited
Loading

Description

Refactoring of proposed feature:

  • Adhere more closely to delegate pattern
  • Abstract out the encoding/ decoding logic from previous Playground handleHash
  • Migrate out of redux sagas for shared link generation

TODO:

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@chownces chownces changed the title Shared links frontend enrong Shared links frontend refactor Apr 14, 2024
@chownces chownces mentioned this pull request Apr 14, 2024
Draft
7 tasks
RichDom2185
RichDom2185 reviewed Apr 14, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out with this!

src/pages/playground/Playground.tsx Show resolved Hide resolved
src/commons/controlBar/ControlBarShareButton.tsx Outdated Show resolved Hide resolved
src/commons/controlBar/ControlBarShareButton.tsx Show resolved Hide resolved
@chownces chownces force-pushed the shared-links-frontend-enrong branch from 021b849 to b849eb8 Compare April 15, 2024 07:12
@chownces chownces marked this pull request as ready for review April 15, 2024 08:19
@martin-henz martin-henz merged commit cd4760e into shared-links-frontend Apr 15, 2024
6 checks passed
@martin-henz martin-henz deleted the shared-links-frontend-enrong branch April 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 left review comments

@Rachelcoll Rachelcoll Awaiting requested review from Rachelcoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chownces @RichDom2185 @martin-henz