Drop other mutations of && and ||

sourcefrog · Jan 1, 2024 · 796cfb6 · 796cfb6
1 parent 53fb59a
commit 796cfb6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -8,7 +8,7 @@
 
 - New: Mutate `+, -, *, /, %, &, ^, |, <<, >>` binary ops, and their corresponding assignment ops like `+=`.
 
-- Changed: Stop generating mutations of `||` to `!=`, because it seems to raise too many low-value false positives, where the program does not need to care about the case where both operands are true.
+- Changed: Stop generating mutations of `||` and `&&` to `!=` and `||`, because it seems to raise too many low-value false positives that may be hard to test.
 
 ## 23.12.1
 

diff --git a/src/visit.rs b/src/visit.rs
@@ -362,8 +362,8 @@ impl<'ast> Visit<'ast> for DiscoveryVisitor<'_> {
             // because they require parenthesis for disambiguation in many expressions.
             BinOp::Eq(_) => vec![quote! { != }],
             BinOp::Ne(_) => vec![quote! { == }],
-            BinOp::And(_) => vec![quote! { || }, quote! {!=}],
-            BinOp::Or(_) => vec![quote! { && }, quote! {==}],
+            BinOp::And(_) => vec![quote! { || }],
+            BinOp::Or(_) => vec![quote! { && }],
             BinOp::Lt(_) => vec![quote! { == }, quote! {>}],
             BinOp::Gt(_) => vec![quote! { == }, quote! {<}],
             BinOp::Le(_) => vec![quote! {>}],