Run a GNU jobserver shared across all children #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317
std::process::Command, since jobserver supports specifically that Revert to using stdlib Command, not subprocess #376--jobserver BOOLoption to allow turning it off if it causes trouble--jobserver-slots Nto configure the number of slots away from the default of NCPUSCI job to test it?- It's on by default and should be covered by the default jobsThis seems hard to test; what we really care about is the maximum number of
rustcor similar child processes ever spawned at any moment. In principle we could runpsand parse the output, at least on Unix, but in fact this would be slightly racy because it probably doesn't observe the whole process tree, and so the test might be slightly flaky...