Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run Clippy on all platforms #452

Merged
merged 7 commits into from
Dec 8, 2024
Merged

ci: Run Clippy on all platforms #452

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
422dc68
ci: Check rustfmt/clippy on all platforms
sourcefrog Nov 20, 2024
dce7fce
fix: Install clippy
sourcefrog Nov 20, 2024
c9cd209
Merge remote-tracking branch 'origin/main' into ci-clippy-matrix
sourcefrog Nov 21, 2024
ba4b99b
Merge branch 'main' into ci-clippy-matrix
sourcefrog Nov 22, 2024
1bf7708
Only enforce clippy on stable
sourcefrog Nov 22, 2024
c4098bd
Merge remote-tracking branch 'origin/main' into ci-clippy-matrix
sourcefrog Nov 22, 2024
f26bc17
Merge branch 'main' into ci-clippy-matrix
sourcefrog Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ jobs:
run: |
cargo --version
rustc --version
# TODO: Maybe also check clippy and rustfmt here.
- name: Build
run: cargo build --all-targets
- uses: taiki-e/install-action@v2
Expand All @@ -71,8 +70,7 @@ jobs:
- name: Check rustfmt
run: cargo fmt --all --check
- name: Check clippy
# TODO: -- -D warnings
run: cargo clippy --all-targets --all-features
run: cargo clippy --all-targets --all-features -- -D warnings
- name: Check typos
uses: crate-ci/typos@master
- name: Build release binary
Expand Down Expand Up @@ -115,8 +113,10 @@ jobs:
- name: Check rustfmt
run: cargo fmt --all --check
- name: Check clippy
# TODO: Deny warnings
run: cargo clippy --all-targets --all-features
if: matrix.version == 'stable'
# Clippy checks can vary between versions in a way that makes it a bit
# fiddly to satisfy them all, so only insist that they pass on stable.
run: cargo clippy --all-targets --all-features -- -D warnings
- run: cargo update
- name: Test after cargo update
run: cargo test --workspace
Expand Down
Loading