remove ChatSubmitType user-newchat #5792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
sqs/chat-submittype
branch
2 times, most recently
from
b352175
to
d95e593
Compare
The `user` `ChatSubmitType` was used in 2 places: - For edits in ChatController (an internal use, replaced with `isEdit`) - For custom commands Since custom commands are being removed and the "reuse existing chat window" of custom commands is not important to preserve even for now, we can simplify the code by removing this mode and `submitType` throughout.
sqs
force-pushed
the
sqs/chat-submittype
branch
from
d95e593
to
99d3edc
Compare
|
@abeatrix Thanks! For that PR, it looks like your suggestion is to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This controlled whether a chat would reuse the same window or create a new one. Replies and edits reuse the same chat window, but everything else (except for custom commands, optionally) starts a new chat.
The only user-facing behavior change is for custom commands (described below).
The
userChatSubmitTypewas used in 2 places:Since custom commands are being removed and the "reuse existing chat window" of custom commands is not important to preserve even for now, we can simplify the code by removing this mode and
submitTypethroughout.Test plan
CI & e2e